Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbcKRWpM (ORCPT ); Fri, 18 Nov 2016 17:45:12 -0500 Received: from vern.gendns.com ([206.190.152.46]:48632 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbcKRWpK (ORCPT ); Fri, 18 Nov 2016 17:45:10 -0500 Subject: Re: [PATCH 1/2] MMC: davinci: use mmc_of_parse to parse common mmc configuration To: Axel Haslam , ulf.hansson@linaro.org, nsekhar@ti.com, khilman@baylibre.com References: <20161115162822.25791-1-ahaslam@baylibre.com> <20161115162822.25791-2-ahaslam@baylibre.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: <65281563-66af-9990-c3c5-a7740b697756@lechnology.com> Date: Fri, 18 Nov 2016 16:45:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161115162822.25791-2-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 16 On 11/15/2016 10:28 AM, Axel Haslam wrote: > Card detect and write protect are currently not working on a DT > boot, and the driver relies on polling to get the state > of the card. The current code depends on platform data callbacks > to register and get the state of the gpios. > > mmc core provides a generic way to parse device tree configuration, > which will take care of registering the gpios for us, lets use it > so that we don't need to poll, and parse the same properties. > > Signed-off-by: Axel Haslam > --- Tested-by: David Lechner Working for me on LEGO MINDSTORMS EV3.