Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752520AbcKSIaO (ORCPT <rfc822;w@1wt.eu>);
        Sat, 19 Nov 2016 03:30:14 -0500
Received: from mail.free-electrons.com ([62.4.15.54]:57700 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751919AbcKSIaN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 19 Nov 2016 03:30:13 -0500
Date: Sat, 19 Nov 2016 09:30:11 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mtd@lists.infradead.org, Alan Cox <alan@linux.intel.com>,
        David Woodhouse <David.Woodhouse@intel.com>,
        Jason Roberts <jason.e.roberts@intel.com>,
        Chuanxiao Dong <chuanxiao.dong@intel.com>,
        Dinh Nguyen <dinguyen@altera.com>, linux-kernel@vger.kernel.org,
        Marek Vasut <marek.vasut@gmail.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: Re: [PATCH 00/11] mtd: nand: denali: first round of cleanups of
 Denali NAND driver
Message-ID: <20161119093011.17b53356@bbrezillon>
In-Reply-To: <1478666130-13413-1-git-send-email-yamada.masahiro@socionext.com>
References: <1478666130-13413-1-git-send-email-yamada.masahiro@socionext.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2055
Lines: 51

Hi Masahiro,

On Wed,  9 Nov 2016 13:35:19 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> I am tackling on this driver to use it for my SoCs.
> The difficulty is a bunch of platform specific stuff
> (more specifically, Intel MRST specific) is hard-coded in this driver.
> 
> I need lots of rework to utilize the driver for generic cases,
> but at the same time, I found the driver code is really dirty,
> lots of unused code, odd comments, etc.
> 
> The first thing I needed to do was to clean up the code.
> My work is still under the way, but I decided to drop this series
> for now.  I hope this series is easy to review, so I guess
> splitting into a small chunks is better than a one-shot patch bomb.

Well, all I've seen coming from you so far are minor cleanups and
cosmetic changes (including one introducing a regression).
I'll apply this series, but please, next time, try to send the whole
series, so that we can see the big picture, and not just random
cleanups.

Thanks,

Boris

> 
> 
> 
> Masahiro Yamada (11):
>   mtd: nand: denali: remove unneeded <linux/slab.h> includes
>   mtd: nand: denali: remove unused struct member denali_nand_info::idx
>   mtd: nand: denali: remove bogus comment about interrupt handler setup
>   mtd: nand: denali: remove detect_partition_feature()
>   mtd: nand: denali: remove "Spectra:" prefix from printk strings
>   mtd: nand: denali: remove unused struct member totalblks, blksperchip
>   mtd: nand: denali: use managed devm_irq_request()
>   mtd: nand: denali: return error code from devm_request_irq() on error
>   mtd: nand: denali: return error code from nand_scan_ident/tail on
>     error
>   mtd: nand: denali: remove unneeded parentheses
>   mtd: nand: denali: remove debug lines of __FILE__, __LINE__, __func__
> 
>  drivers/mtd/nand/denali.c     | 101 +++++++++---------------------------------
>  drivers/mtd/nand/denali.h     |  12 -----
>  drivers/mtd/nand/denali_dt.c  |   1 -
>  drivers/mtd/nand/denali_pci.c |   1 -
>  4 files changed, 21 insertions(+), 94 deletions(-)
>