Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753440AbcKSPtt (ORCPT <rfc822;w@1wt.eu>);
        Sat, 19 Nov 2016 10:49:49 -0500
Received: from mail-it0-f49.google.com ([209.85.214.49]:38904 "EHLO
        mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752985AbcKSPtr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 19 Nov 2016 10:49:47 -0500
MIME-Version: 1.0
In-Reply-To: <180196e3754572540b595bc56b947d43658979a7.1479491159.git.jpoimboe@redhat.com>
References: <180196e3754572540b595bc56b947d43658979a7.1479491159.git.jpoimboe@redhat.com>
From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Sat, 19 Nov 2016 16:49:46 +0100
Message-ID: <CAFTL4hwet4+rm+y=EX=K1G+x7G+qk0+un8X4K2dJ3QBTeNbttw@mail.gmail.com>
Subject: Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "the arch/x86 maintainers" <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 892
Lines: 42

2016-11-18 18:46 GMT+01:00 Josh Poimboeuf <jpoimboe@redhat.com>:
> NMI stack dumps are bracked by the following tags:
>
>   <NMI>
>   ...
>   <EOE>
>
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception).  The same ending tag is also used to mark the
> end of all other exceptions' stacks.  For example:
>
>   <#DF>
>   ...
>   <EOE>
>
> And similarly, "EOI" is used as the ending tag for interrupts:
>
>   <IRQ>
>   ...
>   <EOI>
>
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
>
>   <NMI>
>   ...
>   </NMI>
>
>   <#DF>
>   ...
>   </#DF>
>
>   <IRQ>
>   ...
>   </IRQ>
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

I like that! I hope not too many tools rely on the old namings.
But dmesg isn't supposed to be a stable ABI anyway.

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>