Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbcKSQoB (ORCPT ); Sat, 19 Nov 2016 11:44:01 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33327 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbcKSQn7 (ORCPT ); Sat, 19 Nov 2016 11:43:59 -0500 Date: Sun, 20 Nov 2016 00:43:56 +0800 From: Hao Zhang To: vinod.koul@intel.com, dan.j.williams@intel.com, wens@csie.org, maxime.ripard@free-electrons.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@lists.infradead.org, hao5781286@gmail.com Subject: [PATCH v2] dmaengine: sun6i: fix the uninitialized value for v_lli Message-ID: <20161119164356.GA15368@arx12> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 29 dma_pool_alloc does not initialize the value of the newly allocated block for the v_lli, and the uninitilize value make the tests failed which is on pine64 with dmatest. we can fix it just change the "|=" to "=" for the v_lli->cfg. Signed-off-by: Hao Zhang --- v1: https://www.spinics.net/lists/arm-kernel/msg539966.html Changes in v1: -Remove ARM and add spaces after each tag in the title drivers/dma/sun6i-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index 8346199..a235878 100644 --- a/drivers/dma/sun6i-dma.c +++ b/drivers/dma/sun6i-dma.c @@ -578,7 +578,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_memcpy( burst = convert_burst(8); width = convert_buswidth(DMA_SLAVE_BUSWIDTH_4_BYTES); - v_lli->cfg |= DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) | + v_lli->cfg = DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) | DMA_CHAN_CFG_DST_DRQ(DRQ_SDRAM) | DMA_CHAN_CFG_DST_LINEAR_MODE | DMA_CHAN_CFG_SRC_LINEAR_MODE | -- 2.7.4