Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753046AbcKSSZj (ORCPT ); Sat, 19 Nov 2016 13:25:39 -0500 Received: from mail-wj0-f195.google.com ([209.85.210.195]:33990 "EHLO mail-wj0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbcKSSZi (ORCPT ); Sat, 19 Nov 2016 13:25:38 -0500 Subject: Re: [PATCH] coresight: perf: Add a missing call to etm_free_aux To: Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20161119174124.20136-1-lambert.quentin@gmail.com> From: Quentin Lambert Message-ID: <3e105f1d-c984-358f-a996-b9d3a2d01e0d@gmail.com> Date: Sat, 19 Nov 2016 19:22:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161119174124.20136-1-lambert.quentin@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 29 On 11/19/2016 06:41 PM, Quentin Lambert wrote: > Most error branches following the call to alloc_event_data contain a call to > etm_free_aux. This patch add a call to etm_free_aux to an error branch > that does not call it. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -215,7 +215,7 @@ static void *etm_setup_aux(int event_cpu > */ > sink = coresight_get_enabled_sink(true); > if (!sink) > - return NULL; > + goto err; > > INIT_WORK(&event_data->work, free_event_data); > I realized that I hadn't try to compile after having sent this patch and I wasn't able to compile it. Therefore, please ignore it for now. Quentin