Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbcKTCrm (ORCPT ); Sat, 19 Nov 2016 21:47:42 -0500 Received: from smtp.math.uni-bielefeld.de ([129.70.45.10]:51816 "EHLO smtp.math.uni-bielefeld.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbcKTCrk (ORCPT ); Sat, 19 Nov 2016 21:47:40 -0500 From: Tobias Jakobi Subject: commit 4dd1837d7589f468ed109556513f476e7a7f9121 breaks build To: viro@zeniv.linux.org.uk Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Message-ID: <58310EC6.4020402@math.uni-bielefeld.de> Date: Sun, 20 Nov 2016 03:47:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 43 Hello, this is a resend of my initial mail, see below, to Al Viro (which sadly was ignored). It's rc5 now, and this issue still remains. Putting some more lists on the Cc now. Reverting the commit still works for me. With best wishes, Tobias ---------------- Hello Al, compiled a kernel on armv7 with torvalds/master today and getting some errors during the modpost phase. > ERROR: "_set_bit" [sound/usb/snd-usbmidi-lib.ko] undefined! > ERROR: "_test_and_set_bit" [sound/usb/snd-usbmidi-lib.ko] undefined! > ERROR: "_clear_bit" [sound/usb/snd-usbmidi-lib.ko] undefined! > ERROR: "_test_and_clear_bit" [sound/usb/snd-usb-audio.ko] undefined! > ERROR: "_set_bit" [sound/usb/snd-usb-audio.ko] undefined! > ERROR: "_test_and_set_bit" [sound/usb/snd-usb-audio.ko] undefined! > ERROR: "_clear_bit" [sound/usb/snd-usb-audio.ko] undefined! > ERROR: "_test_and_clear_bit" [sound/core/seq/snd-seq.ko] undefined! It seems like the commit 'arm: move exports to definitions' introduces this issue. I quickly went over the commit and I noticed that while it removes the EXPORT_SYMBOL()s for the bitops from armksyms.c, it doesn't move them anywhere. Maybe you can take a look at this? With best wishes, Tobias