Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbcKTJjY (ORCPT ); Sun, 20 Nov 2016 04:39:24 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35660 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753121AbcKTJjX (ORCPT ); Sun, 20 Nov 2016 04:39:23 -0500 Date: Sun, 20 Nov 2016 10:39:32 +0100 From: Greg KH To: Davidlohr Bueso Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE Message-ID: <20161120093932.GA21152@kroah.com> References: <1479585265-7906-1-git-send-email-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479585265-7906-1-git-send-email-dave@stgolabs.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 899 Lines: 26 On Sat, Nov 19, 2016 at 11:54:25AM -0800, Davidlohr Bueso wrote: > With the new standardized functions, we can replace all ACCESS_ONCE() > calls across relevant drivers/usb/. > > ACCESS_ONCE() does not work reliably on non-scalar types. For example > gcc 4.6 and 4.7 might remove the volatile tag for such accesses during > the SRA (scalar replacement of aggregates) step: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Update the new calls regardless of if it is a scalar type, this is > cleaner than having three alternatives. > > Signed-off-by: Davidlohr Bueso Nit, this doesn't match your From: line :( If this is the case, why not just replacing the define for ACCESS_ONCE() with READ_ONCE() and then go back and just do a search/replace for the whole kernel all at once? Or just send Linus a patch for this all at once after -rc1 is out? thanks, greg k-h