Date: Sun, 20 Nov 2016 23:52:07 +0600
From: Alexnader Kuleshov <kuleshovmail@gmail.com>
To: open list <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Jan Beulich <jbeulich@suse.com>, Tony Luck <tony.luck@intel.com>,
        Jianyu Zhan <nasa4836@gmail.com>
Subject: Question: goal of twice disabling of preemption in exception handlers
Message-ID: <20161120175207.GA4354@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.6.0-rc0 ((null))
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 726
Lines: 14

Hello everyone,

Exception handlers which may run on IST stack disable and enable preemption
twice. For example do_int3() [1]. This one calls ist_enter() which
disables preemption with preempt_disable() every time without any conditions.
And later do_int3() calls preempt_disable() again [2] before do_trap().

Of course we decrement preemption counter in the end of such exception
handlers twice too. But what's actual purpose of doing this two times?

[1] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/x86/kernel/traps.c?id=refs/tags/next-20161117#n530
[2] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/x86/kernel/traps.c?id=refs/tags/next-20161117#n566

Thank you.