Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753596AbcKTV0c (ORCPT ); Sun, 20 Nov 2016 16:26:32 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:63061 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbcKTV02 (ORCPT ); Sun, 20 Nov 2016 16:26:28 -0500 From: Stefan Wahren To: John Youn , Vardan Mikayelyan , Greg Kroah-Hartman Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH 1/5] usb: dwc2: Do not set host parameter in peripheral mode Date: Sun, 20 Nov 2016 21:26:02 +0000 Message-Id: <1479677166-13114-2-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> References: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K0:/xiNnqyO7GasLuMbkWeLfdw66ombJ7A9e4LFQ0khgXKPqV6pnpt SqjsUM3D1qxOMkBXiKCHPGwvNkXD1LOu5krIUK1SKZPREfZKVkuZYEfa2ww+bI+9Ln4Ybi/ KUsCRyvzi13DrJUQtqrmIUYRyZ+WIzIJ5s9EDvb5lSBLwQeRjmv2B+1aXZjS9XE4rqqC9Hr 0ZG4OJZzyklQfFGOseHFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:XTIXUIucBPI=:mVmD0ABSI4Xq84NZkE1SGn zo6ejKcSn/boaSBU2AY1k4d1rAlSaLoIYsn8vMp8iFugwtcwrLGfkhZT3FqxGc9Av1pow8Js7 OEQGBb9hgm7Z+asNcGAOYbaFnG/oFYCX0aJP7bCh37RLauyq+9Cb/SlLUfKP8dwxiDsrpHl2W cr5vWVJJtyZB4oHM8zYyIJ3wLPbR+nbh49V4EDp8O9Kn6tIsfUDwo4UkY5cTsULHkc7UWFt3y FWy2z95/zFgKKPsh86IiAV1P/bYWNnJgDnUcSbMZ+O7yEctCZC0BumZXrPN+Y1wFfFy1Ql08R IUMGPJfK5h/L1aMg5hIkiLwKTMazF7EtduYQm9GbVk6duVbTXN4jUu0Shqa7a5IAtp3pFNo3+ f04eS7+MTvr+Pbkax7qRGIDKGUAGT5aEQqdUWYHlrLqYsznsQNdfuRHyFw2lB8Ykm1vQr+6KS A6FRnftAx/7whfCt7ozkqmUoEBdraCWTKOmmfVOEs9OOVPjAWz0iIaYaw3xAosWPAEMYQpctf PgFxKa9/vWI7AaHVEHMrzXmzE0PVWYQHQu4ecPtDNOJLKAmcxvKa3yi/sU5t51dCshtiShAkP wnvJRTCe+hRiXXs9YmT7Ag1HRjOZuPz4Gz0dN5CG02dqUFA6/P+qwdjeI/gPAm2fiYyD+0WfW mzIQRRHi2vAFGCFN1TC9FwCKf/41y3u7HydKKQwqEnLo5hoDb8Wio057K6KQftqyobWM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1937 Lines: 46 Since commit "usb: dwc2: Improve handling of host and device hwparams" the host mode specific hardware parameter aren't initialized in peripheral mode from the register settings anymore. So we better do not set them in this case which avoids the following warnings on bcm2835: 256 invalid for host_nperio_tx_fifo_size. Check HW configuration. 512 invalid for host_perio_tx_fifo_size. Check HW configuration. Fixes: 55e1040e424b ("usb: dwc2: Improve handling of host and device hwparams") Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/params.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index a786256..fd5f7f8 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -1132,6 +1132,12 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg, false, "host-dma", true, false, dma_capable); + dwc2_set_param_host_rx_fifo_size(hsotg, + params->host_rx_fifo_size); + dwc2_set_param_host_nperio_tx_fifo_size(hsotg, + params->host_nperio_tx_fifo_size); + dwc2_set_param_host_perio_tx_fifo_size(hsotg, + params->host_perio_tx_fifo_size); } dwc2_set_param_dma_desc_enable(hsotg, params->dma_desc_enable); dwc2_set_param_dma_desc_fs_enable(hsotg, params->dma_desc_fs_enable); @@ -1140,12 +1146,6 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg, params->host_support_fs_ls_low_power); dwc2_set_param_enable_dynamic_fifo(hsotg, params->enable_dynamic_fifo); - dwc2_set_param_host_rx_fifo_size(hsotg, - params->host_rx_fifo_size); - dwc2_set_param_host_nperio_tx_fifo_size(hsotg, - params->host_nperio_tx_fifo_size); - dwc2_set_param_host_perio_tx_fifo_size(hsotg, - params->host_perio_tx_fifo_size); dwc2_set_param_max_transfer_size(hsotg, params->max_transfer_size); dwc2_set_param_max_packet_count(hsotg, -- 1.7.9.5