Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbcKTV0b (ORCPT ); Sun, 20 Nov 2016 16:26:31 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:59890 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbcKTV02 (ORCPT ); Sun, 20 Nov 2016 16:26:28 -0500 From: Stefan Wahren To: John Youn , Vardan Mikayelyan , Greg Kroah-Hartman Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH 2/5] usb: dwc2: fix dwc2_get_device_property for u8 and u16 Date: Sun, 20 Nov 2016 21:26:03 +0000 Message-Id: <1479677166-13114-3-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> References: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K0:c8JD5hdmiazuKcpVw7DSQbEjdb0/ypwsFis3cV/w+QyaQ94lm+T a96ILtRM9EjTgFPaOzkTpibVW8y0zEqe9sK2Ub82X8mT7LbFYZh8LM8QJx0yybQsMFkA6F9 wtCMuaKW2xzMsj3TUsQnLOKSFhKqADznJUUAQELoRyNyXezaxoKc1UNtzFsA0jgnScP5Mz2 CsnJFO0bwb5yR4dYFzSBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:dJ0fZ0c05zs=:BNjvgDQmRbDu7AUqm8uKlr ut+5WeaqVdQT4XeZbbeGYHfc8iMrfgQPulPTX+GAXDU9nnJSCsHGMDEItKn8G81MCZ1c4zeAx z2OSSBYS2uqIdzf5R9H7PVWoHGnqxKL98fK7P05LErJzkXj1UeheZE4BmrNqmO/4+ZG/WKFyI WoXepDYsLmq2e13+ijtJXQWH8Sn7ixwi93mgjo31pTjbLi3IXA99ZMez4vBnutrSqtS7/QZTM EDuvGjfMZV6+8Gw2B65lN8LIiumBCC6WP9NhruXqPq92RzD2u9aI2+8CUo0MtZiuXsd10t6OI vCxfl21fbto5nNCbKQlx31owuSj2DjuC+kZ3oMnqfxydT0lVEuJ69ofVoKi+p30n1dKyKoaFR xJskvxzaHHXtlFYDMkiYKrSej78U6oosrOKLwDzYIyBNzTUkmLy7o1GXX/EAPXHFSdUgFEvi4 rkxl7rEEvM25s2ahVC5qQPnYQ53CPUv+lX7s/qGeMmAV+xrcMmzKE6Z4hHlGoqFJtKjnE8yTv 7tNnIvASBTxrW4O2yMTmnUBN0N6kB73nYVCniHwW6QV4X25Xx0swcVcX+A9motiD0oPXJVl0W Rz2c45jAIN0oSokHAZqWzsjUYvvjowj4NcvgdVA3bfghCxye2I4x23b0K3Gd5xu5kX7QW/me7 Lyeda1GWJM/S0T3Kzpr1cI327FbCFveUnuVMhAn74mYSnxCS3TqOx6tcsPRC7HB42z00= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 51 According to the Devicetree ePAPR [1] the datatypes u8 and u16 are not defined. So using device_property_read_u16() would result in a partial read of a 32-bit big-endian integer which is not intended. So we better read the complete 32-bit value. This fixes a regression on bcm2835 where the values for g-rx-fifo-size and g-np-tx-fifo-size always read as zero: Invalid value 0 for param g-rx-fifo-size Invalid value 0 for param g-np-tx-fifo-size [1] - http://elinux.org/images/c/cf/Power_ePAPR_APPROVED_v1.1.pdf Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/params.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index fd5f7f8..2c7b624 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -247,8 +247,6 @@ static void dwc2_get_device_property(struct dwc2_hsotg *hsotg, char *property, u8 size, u64 *value) { - u8 val8; - u16 val16; u32 val32; switch (size) { @@ -256,17 +254,7 @@ static void dwc2_get_device_property(struct dwc2_hsotg *hsotg, *value = device_property_read_bool(hsotg->dev, property); break; case 1: - if (device_property_read_u8(hsotg->dev, property, &val8)) - return; - - *value = val8; - break; case 2: - if (device_property_read_u16(hsotg->dev, property, &val16)) - return; - - *value = val16; - break; case 4: if (device_property_read_u32(hsotg->dev, property, &val32)) return; -- 1.7.9.5