Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbcKUCYr (ORCPT ); Sun, 20 Nov 2016 21:24:47 -0500 Received: from mail-qk0-f176.google.com ([209.85.220.176]:36712 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbcKUCYq (ORCPT ); Sun, 20 Nov 2016 21:24:46 -0500 MIME-Version: 1.0 In-Reply-To: <871sy8g83q.fsf@ashishki-desk.ger.corp.intel.com> References: <1479438454-28650-1-git-send-email-zhang.chunyan@linaro.org> <1479438454-28650-4-git-send-email-zhang.chunyan@linaro.org> <871sy8g83q.fsf@ashishki-desk.ger.corp.intel.com> From: Chunyan Zhang Date: Mon, 21 Nov 2016 10:24:44 +0800 Message-ID: Subject: Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace To: Alexander Shishkin Cc: Steven Rostedt , Mathieu Poirier , mingo@redhat.com, Mike Leach , Tor Jeremiassen , philippe.langlais@st.com, Nicolas GUION , Felipe Balbi , Lyra Zhang , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 36 On 18 November 2016 at 22:45, Alexander Shishkin wrote: > Chunyan Zhang writes: > >> If CONFIG_STM_SOURCE_FTRACE is selected, Function trace data can be writen >> to sink via STM, all functions that related to writing data packets to >> STM should be marked 'notrace' to avoid being traced by Ftrace, otherwise >> the program would stall into an endless loop. >> >> Signed-off-by: Chunyan Zhang >> Acked-by: Steven Rostedt >> --- >> drivers/hwtracing/coresight/coresight-stm.c | 2 +- >> drivers/hwtracing/intel_th/sth.c | 11 +++++++---- >> drivers/hwtracing/stm/core.c | 7 ++++--- >> drivers/hwtracing/stm/dummy_stm.c | 2 +- >> include/linux/stm.h | 4 ++-- >> 5 files changed, 15 insertions(+), 11 deletions(-) > > Quick nit: can you please split this one in 4: one for Coresight, one > for Intel TH, one for stm/dummy and one for stm/core? Sure, will do. > > I'd like to keep the bisectability. Otherwise, this is fine by me: > > Acked-by: Alexander Shishkin Thanks, Chunyan > > Regards, > -- > Alex