Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbcKUCmf (ORCPT ); Sun, 20 Nov 2016 21:42:35 -0500 Received: from vern.gendns.com ([206.190.152.46]:50900 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbcKUCmd (ORCPT ); Sun, 20 Nov 2016 21:42:33 -0500 Subject: Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node To: Axel Haslam , nsekhar@ti.com, khilman@kernel.org, robh+dt@kernel.org, Alexandre Bailon References: <20161107203948.28324-1-ahaslam@baylibre.com> <20161107203948.28324-11-ahaslam@baylibre.com> Cc: stern@rowland.harvard.edu, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <48d0c158-f7c8-0d1e-f06e-b7b28d6f2b93@lechnology.com> Date: Sun, 20 Nov 2016 20:42:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161107203948.28324-11-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 56 On 11/07/2016 02:39 PM, Axel Haslam wrote: > This adds the ohci device node for the da850 soc. > It also enables it for the omapl138 hawk board. > > Signed-off-by: Axel Haslam > --- > arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ > arch/arm/boot/dts/da850.dtsi | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 7b8ab21..aaf533e 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -86,6 +86,14 @@ > }; > }; > > +&usb_phy { > + status = "okay"; > +}; > + > +&ohci { > + status = "okay"; > +}; > + > &serial2 { > pinctrl-names = "default"; > pinctrl-0 = <&serial2_rxtx_pins>; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 2534aab..50e86da 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -405,6 +405,14 @@ > >; > status = "disabled"; > }; > + ohci: usb@0225000 { In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci tree, the alias for the musb device is usb0. So, I think we should use usb1 here instead of ohci - or change the usb0 alias to musb. https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6 > + compatible = "ti,da830-ohci"; > + reg = <0x225000 0x1000>; > + interrupts = <59>; > + phys = <&usb_phy 1>; > + phy-names = "usb-phy"; > + status = "disabled"; > + }; > gpio: gpio@226000 { > compatible = "ti,dm6441-gpio"; > gpio-controller; >