Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290AbcKUH1c (ORCPT ); Mon, 21 Nov 2016 02:27:32 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33751 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbcKUH13 (ORCPT ); Mon, 21 Nov 2016 02:27:29 -0500 Date: Mon, 21 Nov 2016 18:27:14 +1100 From: Nicholas Piggin To: Adam Borowski Cc: Peter Wu , Vince Weaver , Michal Marek , Al Viro , Oliver Hartkopp , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, regressions@leemhuis.info, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Arnd Bergmann Subject: Re: [PATCH resend] kbuild: provide include/asm/asm-prototypes.h for x86 Message-ID: <20161121182714.2cd5da75@roar.ozlabs.ibm.com> In-Reply-To: <20161121063945.6586-1-kilobyte@angband.pl> References: <20161121164940.33b555ea@roar.ozlabs.ibm.com> <20161121063945.6586-1-kilobyte@angband.pl> Organization: IBM X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2932 Lines: 79 Hi Adam, Thanks. I'd suggest doing x86: or x86/kbuild: prefix for the patch. Also possibly consider describing what the patch does at a higher level in your subject line, e.g.: x86/kbuild: enable modversions for symbols exported from asm Also, it wouldn't hurt to add a little changelog of your own. Describe problem then solution, e.g., Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds modversion support for symbols exported from asm files. Architectures must include C-style declarations for those symbols in asm/asm-prototypes.h in order for them to be versioned. Add these declarations for x86, and an architecture-independent file that can be used for common symbols. (if you want to use that as-is or rewrite it, no problem). You can add Acked-by: Nicholas Piggin Also it's not a big deal, but if you redo the patch, you could consider splitting it into two (first add the generic header, then the x86 header), but both can go via the x86 tree. Thanks, Nick On Mon, 21 Nov 2016 07:39:45 +0100 Adam Borowski wrote: > Nicholas Piggin wrote: > > Architectures will need to have an include/asm/asm-prototypes.h that > > defines or #include<>s C-style prototypes for exported asm functions. > > We can do an asm-generic version for the common ones like memset so > > there's not a lot of pointless duplication there. > > Signed-off-by: Adam Borowski > Tested-by: Kalle Valo > --- > arch/x86/include/asm/asm-prototypes.h | 12 ++++++++++++ > include/asm-generic/asm-prototypes.h | 7 +++++++ > 2 files changed, 19 insertions(+) > create mode 100644 arch/x86/include/asm/asm-prototypes.h > create mode 100644 include/asm-generic/asm-prototypes.h > > diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h > new file mode 100644 > index 0000000..ae87224 > --- /dev/null > +++ b/arch/x86/include/asm/asm-prototypes.h > @@ -0,0 +1,12 @@ > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include > +#include > +#include > +#include > diff --git a/include/asm-generic/asm-prototypes.h b/include/asm-generic/asm-prototypes.h > new file mode 100644 > index 0000000..df13637 > --- /dev/null > +++ b/include/asm-generic/asm-prototypes.h > @@ -0,0 +1,7 @@ > +#include > +extern void *__memset(void *, int, __kernel_size_t); > +extern void *__memcpy(void *, const void *, __kernel_size_t); > +extern void *__memmove(void *, const void *, __kernel_size_t); > +extern void *memset(void *, int, __kernel_size_t); > +extern void *memcpy(void *, const void *, __kernel_size_t); > +extern void *memmove(void *, const void *, __kernel_size_t);