Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbcKUHau (ORCPT ); Mon, 21 Nov 2016 02:30:50 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:49243 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbcKUHat (ORCPT ); Mon, 21 Nov 2016 02:30:49 -0500 Date: Mon, 21 Nov 2016 08:30:47 +0100 From: Maxime Ripard To: Daniel Vetter , David Airlie , Thomas Petazzoni , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans de Goede , Chen-Yu Tsai , Laurent Pinchart , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] drm/sun4i: Add support for the overscan profiles Message-ID: <20161121073047.zv5cfjd3ti4hh4gl@lukather> References: <20161108085927.ibyett46cjgyfwu2@phenom.ffwll.local> <20161110145630.wvzlh6rxusrufv2r@lukather> <20161111091755.tfqizju5voazjrmm@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h36kt3wqdavsqeaz" Content-Disposition: inline In-Reply-To: <20161111091755.tfqizju5voazjrmm@phenom.ffwll.local> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2693 Lines: 71 --h36kt3wqdavsqeaz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2016 at 10:17:55AM +0100, Daniel Vetter wrote: > On Thu, Nov 10, 2016 at 03:56:30PM +0100, Maxime Ripard wrote: > > Hi Daniel, > >=20 > > On Tue, Nov 08, 2016 at 09:59:27AM +0100, Daniel Vetter wrote: > > > On Tue, Oct 18, 2016 at 10:29:38AM +0200, Maxime Ripard wrote: > > > > Create overscan profiles reducing the displayed zone. > > > >=20 > > > > For each TV standard (PAL and NTSC so far), we create 4 more reduce= d modes > > > > by steps of 5% that the user will be able to select. > > > >=20 > > > > Signed-off-by: Maxime Ripard > > >=20 > > > tbh I think if we agree to do this (and that still seems an open ques= tion) > > > I think there should be a generic helper to add these overscan modes = with > > > increased porches. Anything that only depends upon the sink (and > > > overscanning is something the sink does) should imo be put into a sui= table > > > helper library for everyone to share. > > >=20 > > > Or maybe even stash it into the probe helpers and call it for all TV > > > connectors. Definitely not a driver-private thing. > >=20 > > Last time we discussed it, my recollection was that you didn't want to > > have generic code for it, but I'd be happy to implement it. > >=20 > > I'll come up with something like that. >=20 > Well I can flip-flop around with the nonsense I'm sometimes emitting ;-) > Since you called me out, feel free to do whatever you want ... I also found the generic solution to be a much better solution, so I'll definitely implement it :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --h36kt3wqdavsqeaz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYMqKmAAoJEBx+YmzsjxAgkTEP/3uLWIAq9Nr8OthDHmPALc5P 7zAlfdrTrxEoCgxsCy5CuUoGcG/1JvBHxcNHNeakzuF0BnA8bTPhZjhF9qBygvuw cnCLg90k4ba3f7Pdo+mH1z/zrIY8xTjG2XryYH7kSt07eQQxq0juCkim/l8ittEx 7CJluIVYTUlgl9x5T2IpW4CVT2HMeGPoUV4PyhktudY5Df7AvD9bWaI+x6gWZGnE V4Gcyh3dLuUeuWsmXhCyws5WpRkM+tGvzf9LjTfCUBZ95nnW4Zx3h6RoppziGX24 Qa4y0PkhDRQ9qVJdq6eQ7k9JNQ9bPcF7eY0voyfE21oVgW3R5Kzs3ODuyACEe89F FVVA1stuStcGdP7RtsbPddeCGA2B8lYKiF9C0byd9jmVrgnSuGT8yWpoNP2KeFMX qEyaa1VjrilvzmPhxZYdMgUY91jDWpZ0iLaFBZWGRl48MGXbONX/PDsm9JLaOsol sU/NVSbabCTpk3b+PfrhcVK2fjAVPZQXQBmUxqTuwQxK1lveUgE/KK3mMVssnGSi brJjLK3Z8bCWWept8rvrOUJnXYsbZ7213yTraecfJ9KyRqblFlL26rU0k7HDjL9A 6Xx5+p0xdP2y4dXOk1vPEXznFC9GuEn5xw124AztZe0j+H1Bn9tyrMA7uUoJLDll Q9I72C6kTybZEEJJ2lEk =KCeF -----END PGP SIGNATURE----- --h36kt3wqdavsqeaz--