Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbcKUKS5 (ORCPT ); Mon, 21 Nov 2016 05:18:57 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37834 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753521AbcKUKS4 (ORCPT ); Mon, 21 Nov 2016 05:18:56 -0500 From: Dmitry Vyukov To: jgunthorpe@obsidianresearch.com, Valdis.Kletnieks@vt.edu, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, leon@kernel.org Cc: Dmitry Vyukov , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com Subject: [PATCH v2] infiniband: remove WARN that is not kernel bug Date: Mon, 21 Nov 2016 11:18:50 +0100 Message-Id: <1479723531-17940-1-git-send-email-dvyukov@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 41 WARNINGs mean kernel bugs. The one in ucma_write() points to user programming error or a malicious attempt. This is not a kernel bug, remove it. BUG/WARNs that are not kernel bugs hinder automated testing effots. Signed-off-by: Dmitry Vyukov Cc: Doug Ledford Cc: Sean Hefty Cc: Hal Rosenstock Cc: Leon Romanovsky Cc: linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: syzkaller@googlegroups.com --- Changes since v1: - added printk_once --- drivers/infiniband/core/ucma.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 9520154..405d0ce 100644 --- a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -1584,8 +1584,11 @@ static ssize_t ucma_write(struct file *filp, const char __user *buf, struct rdma_ucm_cmd_hdr hdr; ssize_t ret; - if (WARN_ON_ONCE(!ib_safe_file_access(filp))) + if (!ib_safe_file_access(filp)) { + printk_once("ucma_write: process %d (%s) tried to do something hinky\n", + task_tgid_vnr(current), current->comm); return -EACCES; + } if (len < sizeof(hdr)) return -EINVAL; -- 2.8.0.rc3.226.g39d4020