Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbcKULmb (ORCPT ); Mon, 21 Nov 2016 06:42:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42132 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbcKULm3 (ORCPT ); Mon, 21 Nov 2016 06:42:29 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20161117123731.GA11573@wunner.de> References: <20161117123731.GA11573@wunner.de> <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <147933285147.19316.11046583275861569558.stgit@warthog.procyon.org.uk> To: Lukas Wunner Cc: dhowells@redhat.com, keyrings@vger.kernel.org, matthew.garrett@nebula.com, linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/16] efi: Get the secure boot status MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29778.1479728545.1@warthog.procyon.org.uk> Date: Mon, 21 Nov 2016 11:42:25 +0000 Message-ID: <29779.1479728545@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 21 Nov 2016 11:42:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 141 Lines: 9 Hi Lukas, Looking in efi_get_secureboot(), is there a reason: efi_guid_t var_guid = EFI_GLOBAL_VARIABLE_GUID; isn't static const? David