Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271AbcKULwF (ORCPT ); Mon, 21 Nov 2016 06:52:05 -0500 Received: from mail-it0-f52.google.com ([209.85.214.52]:38864 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603AbcKULwC (ORCPT ); Mon, 21 Nov 2016 06:52:02 -0500 MIME-Version: 1.0 In-Reply-To: <29779.1479728545@warthog.procyon.org.uk> References: <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <147933285147.19316.11046583275861569558.stgit@warthog.procyon.org.uk> <20161117123731.GA11573@wunner.de> <29779.1479728545@warthog.procyon.org.uk> From: Ard Biesheuvel Date: Mon, 21 Nov 2016 11:52:01 +0000 Message-ID: Subject: Re: [PATCH 02/16] efi: Get the secure boot status To: David Howells , Linn Crosetto Cc: Lukas Wunner , keyrings@vger.kernel.org, Matthew Garrett , linux-security-module , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 529 Lines: 17 (+ Linn) On 21 November 2016 at 11:42, David Howells wrote: > Hi Lukas, > > Looking in efi_get_secureboot(), is there a reason: > > efi_guid_t var_guid = EFI_GLOBAL_VARIABLE_GUID; > > isn't static const? > Not a good one, no. It used to be static const, but for some reason, commit 30d7bf034c03 ("efi/arm64: Check SetupMode when determining Secure Boot status") removed the static and the const (and I reviewed it and did not complain AFAIR) I'll gladly take a patch that reinstates that, though.