Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754436AbcKUMlT convert rfc822-to-8bit (ORCPT ); Mon, 21 Nov 2016 07:41:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34822 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753933AbcKUMlS (ORCPT ); Mon, 21 Nov 2016 07:41:18 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <147933285147.19316.11046583275861569558.stgit@warthog.procyon.org.uk> <20161117123731.GA11573@wunner.de> <29779.1479728545@warthog.procyon.org.uk> To: Ard Biesheuvel Cc: dhowells@redhat.com, Linn Crosetto , Lukas Wunner , keyrings@vger.kernel.org, Matthew Garrett , linux-security-module , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/16] efi: Get the secure boot status MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5700.1479732075.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 21 Nov 2016 12:41:15 +0000 Message-ID: <5701.1479732075@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 21 Nov 2016 12:41:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 23 Ard Biesheuvel wrote: > > Looking in efi_get_secureboot(), is there a reason: > > > > efi_guid_t var_guid = EFI_GLOBAL_VARIABLE_GUID; > > > > isn't static const? > > > > Not a good one, no. It used to be static const, but for some reason, > commit 30d7bf034c03 ("efi/arm64: Check SetupMode when determining > Secure Boot status") removed the static and the const (and I reviewed > it and did not complain AFAIR) > I'll gladly take a patch that reinstates that, though. Also, is there a reason that: typedef efi_status_t efi_get_variable_t (efi_char16_t *name, efi_guid_t *vendor, u32 *attr, unsigned long *data_size, void *data); Doesn't have const name and vendor? David