Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754485AbcKUNF3 (ORCPT ); Mon, 21 Nov 2016 08:05:29 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34259 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbcKUNF0 (ORCPT ); Mon, 21 Nov 2016 08:05:26 -0500 Subject: Re: [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts To: Tony Lindgren , Lee Jones References: <20161028123702.21849-1-woogyom.kim@gmail.com> <20161028123702.21849-6-woogyom.kim@gmail.com> <20161118145353.GE2301@dell.home> <20161118151051.GV4082@atomide.com> Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Nelson From: Milo Kim Message-ID: Date: Mon, 21 Nov 2016 22:05:21 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161118151051.GV4082@atomide.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 14 On 11/19/2016 12:10 AM, Tony Lindgren wrote: >>> +#define TPS65217_IRQ_USB 0 >>> > > +#define TPS65217_IRQ_AC 1 >>> > > +#define TPS65217_IRQ_PB 2 >> > >> > What are "AC" and "PB". Seeing as these are meant to be "human >> > readable", let's make them more human friendly. > Good idea. Milo, please do an incremental single follow-up patch as > I already have applied this and the dts changes using it. Thanks for catching this. Let me send a patch soon. Best regards, Milo