Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754506AbcKUNTs (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Nov 2016 08:19:48 -0500
Received: from mga03.intel.com ([134.134.136.65]:22400 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754061AbcKUNTq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Nov 2016 08:19:46 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,675,1473145200"; 
   d="scan'208";a="194030773"
Date: Mon, 21 Nov 2016 15:17:34 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: undefined reference to `devm_watchdog_register_device'
Message-ID: <20161121131734.GJ1446@lahna.fi.intel.com>
References: <CAOMGZ=EuLB0=HwGcMXj0=gP2Av_sCVg-pm_b5cGeYHnZwhqY0w@mail.gmail.com>
 <CAJZ5v0h=UCNRHrveFwV_hwNLSJ3jZnPDD3WkheVbq24prpnt4g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJZ5v0h=UCNRHrveFwV_hwNLSJ3jZnPDD3WkheVbq24prpnt4g@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 663
Lines: 19

On Mon, Nov 21, 2016 at 02:04:34PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 21, 2016 at 10:07 AM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> > Hi,
> >
> > I updated my config and set CONFIG_WDAT_WDT=y, got this:
> >
> > drivers/built-in.o: In function `wdat_wdt_probe':
> > /home/vegard/linux/drivers/watchdog/wdat_wdt.c:444: undefined
> > reference to `devm_watchdog_register_device'
> > Makefile:962: recipe for target 'vmlinux' failed
> > make: *** [vmlinux] Error 1
> >
> > Looks like it's missing a select for WATCHDOG_CORE in the Kconfig?
> 
> Mika?

That's right - we should select WATCHDOG_CORE there.

I'll submit a patch fixing this shortly.