Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932162AbcKUNXZ (ORCPT ); Mon, 21 Nov 2016 08:23:25 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35535 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753973AbcKUNXY (ORCPT ); Mon, 21 Nov 2016 08:23:24 -0500 Subject: Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree To: John Garry , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20161119174259.20344-1-lambert.quentin@gmail.com> From: Quentin Lambert Message-ID: <0edd4edf-f7c8-053d-7eba-724757dc7d43@gmail.com> Date: Mon, 21 Nov 2016 14:20:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 255 Lines: 9 On 11/21/2016 01:53 PM, John Garry wrote: > However I have noticed that we should do a call to hisi_sas_free() for > this failure, and later failures in the probe. I don't understand why, and would welcome the opportunity to learn something. Quentin