Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754AbcKUPHA (ORCPT ); Mon, 21 Nov 2016 10:07:00 -0500 Received: from lekensteyn.nl ([178.21.112.251]:45592 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754174AbcKUPG6 (ORCPT ); Mon, 21 Nov 2016 10:06:58 -0500 Date: Mon, 21 Nov 2016 16:04:42 +0100 From: Peter Wu To: Adam Borowski Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Arnd Bergmann , Nicholas Piggin , Vince Weaver , Michal Marek , Al Viro , Oliver Hartkopp , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, regressions@leemhuis.info Subject: Re: [PATCH reworded] x86/kbuild: enable modversions for symbols exported from asm Message-ID: <20161121150442.GA963@al> References: <20161121182714.2cd5da75@roar.ozlabs.ibm.com> <20161121145220.10430-1-kilobyte@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161121145220.10430-1-kilobyte@angband.pl> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Score: -0.0 (/) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2807 Lines: 85 On Mon, Nov 21, 2016 at 03:52:20PM +0100, Adam Borowski wrote: > Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds > modversion support for symbols exported from asm files. Architectures > must include C-style declarations for those symbols in asm/asm-prototypes.h > in order for them to be versioned. > > Add these declarations for x86, and an architecture-independent file that > can be used for common symbols. > > User impact: kernels may fail to load modules at all when > CONFIG_MODVERSIONS=y. > > Signed-off-by: Adam Borowski > Tested-by: Kalle Valo > Acked-by: Nicholas Piggin > Tested-by: Peter Wu Typo: oeter@.. -> peter@.. > --- > arch/x86/include/asm/asm-prototypes.h | 12 ++++++++++++ > include/asm-generic/asm-prototypes.h | 7 +++++++ > 2 files changed, 19 insertions(+) > create mode 100644 arch/x86/include/asm/asm-prototypes.h > create mode 100644 include/asm-generic/asm-prototypes.h > > diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h > new file mode 100644 > index 0000000..ae87224 > --- /dev/null > +++ b/arch/x86/include/asm/asm-prototypes.h > @@ -0,0 +1,12 @@ > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include > +#include > +#include > +#include > diff --git a/include/asm-generic/asm-prototypes.h b/include/asm-generic/asm-prototypes.h > new file mode 100644 > index 0000000..df13637 > --- /dev/null > +++ b/include/asm-generic/asm-prototypes.h > @@ -0,0 +1,7 @@ > +#include > +extern void *__memset(void *, int, __kernel_size_t); > +extern void *__memcpy(void *, const void *, __kernel_size_t); > +extern void *__memmove(void *, const void *, __kernel_size_t); > +extern void *memset(void *, int, __kernel_size_t); > +extern void *memcpy(void *, const void *, __kernel_size_t); > +extern void *memmove(void *, const void *, __kernel_size_t); > -- > 2.10.2 > > Now with a better description, provided by Nick Piggin (thanks!), and a > remark about user impact. > > This version doesn't split the patch between x86 vs generic parts, would you > guys prefer that? >From an observer POV: based on the git log include/asm-generic/ arch/x86/include/asm/, a split up seems quite common. By the way, to make the description and discussion closer, you might want to structure your mail like this: [patch description] --- [discussion] --- [actual patch] When applying the patch, the text after the first "---" is automatically dropped. Thanks! Kind regards, Peter