Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754980AbcKUQIK (ORCPT ); Mon, 21 Nov 2016 11:08:10 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:32873 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754349AbcKUQIG (ORCPT ); Mon, 21 Nov 2016 11:08:06 -0500 MIME-Version: 1.0 In-Reply-To: <26198.1479375840@warthog.procyon.org.uk> References: <147931984418.16460.6639993676886095760.stgit@warthog.procyon.org.uk> <147931988803.16460.18213104388363289832.stgit@warthog.procyon.org.uk> <26198.1479375840@warthog.procyon.org.uk> From: Ard Biesheuvel Date: Mon, 21 Nov 2016 16:08:05 +0000 Message-ID: Subject: Re: [PATCH 6/9] efi: Add EFI signature data types To: David Howells Cc: Mat Martineau , keyrings@vger.kernel.org, Matthew Garrett , linux-security-module , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 442 Lines: 13 On 17 November 2016 at 09:44, David Howells wrote: > Mat Martineau wrote: > >> The trailing ';' on EFI_CERT_X509_SHA256_GUID could trip someone up later. As >> long as you're fixing that, the spaces before the closing parens are >> inconsistent with the other GUID definitions in this file. > > Fixed, thanks. > With the fix Reviewed-by: Ard Biesheuvel