Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbcKUQXF (ORCPT ); Mon, 21 Nov 2016 11:23:05 -0500 Received: from foss.arm.com ([217.140.101.70]:36324 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbcKUQXD (ORCPT ); Mon, 21 Nov 2016 11:23:03 -0500 Subject: Re: [PATCH 1/2] of: base: add support to get machine model name To: Frank Rowand References: <1479396775-32033-1-git-send-email-sudeep.holla@arm.com> <582E1A59.7040502@gmail.com> <075d4718-8cd2-e390-b755-bc24e7497eae@arm.com> <582F6312.5040009@gmail.com> <58331B5D.8060907@gmail.com> Cc: linux-kernel@vger.kernel.org, Rob Herring , Sudeep Holla , Arnd Bergmann , devicetree@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <55e27115-421e-b67b-eb7a-9b1c3d662711@arm.com> Date: Mon, 21 Nov 2016 16:23:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <58331B5D.8060907@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 46 On 21/11/16 16:05, Frank Rowand wrote: > Hi Sudeep, > > On 11/18/16 12:22, Frank Rowand wrote: >> On 11/18/16 02:41, Sudeep Holla wrote: >>> >>> >>> On 17/11/16 21:00, Frank Rowand wrote: >>>> On 11/17/16 07:32, Sudeep Holla wrote: >>>>> Currently platforms/drivers needing to get the machine model name are >>>>> replicating the same snippet of code. In some case, the OF reference >>>>> counting is either missing or incorrect. >>>>> >>>>> This patch adds support to read the machine model name either using >>>>> the "model" or the "compatible" property in the device tree root node >>>>> to the core OF/DT code. >>>>> >>>>> This can be used to remove all the duplicate code snippets doing exactly >>>>> same thing later. >>>> >>>> I find five instances of reading only property "model": >>>> >>>> arch/arm/mach-imx/cpu.c >>>> arch/arm/mach-mxs/mach-mxs.c >>>> arch/c6x/kernel/setup.c >>>> arch/mips/cavium-octeon/setup.c >>>> arch/sh/boards/of-generic.c >>>> >>> >>> Ah sorry you were not Cc-ed in 2/2, but that shows all the instances >>> that this will be used for. >> >> I have not seen 2/2. I do not see it on the devicetree list or on lkml. > > Can you please re-send patch 2/2? > Since it is based on -next, I would prefer to wait until next merge window to resend. You should be able to check in the link I sent if that's OK. -- Regards, Sudeep