Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbcKUR5B (ORCPT ); Mon, 21 Nov 2016 12:57:01 -0500 Received: from foss.arm.com ([217.140.101.70]:39250 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbcKUR5A (ORCPT ); Mon, 21 Nov 2016 12:57:00 -0500 Subject: Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver To: Robin Murphy , Bartosz Golaszewski , Sekhar Nori References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-2-git-send-email-bgolaszewski@baylibre.com> Cc: Sudeep Holla , Mark Rutland , linux-devicetree , Tomi Valkeinen , David Airlie , Kevin Hilman , Michael Turquette , Russell King , linux-drm , LKML , Rob Herring , Jyri Sarha , Frank Rowand , arm-soc , Laurent Pinchart From: Sudeep Holla Organization: ARM Message-ID: <6576fc1d-cc16-8d7c-75e7-27c5fbc33101@arm.com> Date: Mon, 21 Nov 2016 17:56:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 37 Hi Robin, On 21/11/16 17:47, Robin Murphy wrote: > Hi Bartosz, Sekhar, > > On 21/11/16 16:48, Bartosz Golaszewski wrote: [...] >> Hi Sekhar, >> >> thanks for spotting that. >> >> I think we should introduce this function right away, rather than >> having two static functions doing the same thing. If you don't mind, >> I'll try to find a good spot for it and send a follow-up series fixing >> the issue. > > As it happens, that was already proposed last week, for much the same > reason: > > http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg111395.html > Thanks for pointing this out, yet another platform to move to the new API after v4.10. Hi Shekar, Bartosz, For v4.10, please continue with the open coding as proposed in this thread in order to avoid cross tree dependencies. I will rework on the above patch once v4.10 merge window closes to include all these occurrence and replace them. -- Regards, Sudeep