Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754587AbcKUSmv (ORCPT ); Mon, 21 Nov 2016 13:42:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:56456 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754104AbcKUSmt (ORCPT ); Mon, 21 Nov 2016 13:42:49 -0500 Date: Mon, 21 Nov 2016 13:42:47 -0500 (EST) Message-Id: <20161121.134247.2230825072060895605.davem@davemloft.net> To: babu.moger@oracle.com Cc: mingo@kernel.org, akpm@linux-foundation.org, ak@linux.intel.com, jkosina@suse.cz, baiyaowei@cmss.chinamobile.com, dzickus@redhat.com, atomlin@redhat.com, uobergfe@redhat.com, tj@kernel.org, hidehiro.kawai.ez@hitachi.com, johunt@akamai.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org Subject: Re: [PATCH v2 0/3] Clean up watchdog handlers From: David Miller In-Reply-To: <1478034826-43888-1-git-send-email-babu.moger@oracle.com> References: <1478034826-43888-1-git-send-email-babu.moger@oracle.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 21 Nov 2016 09:43:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 27 From: Babu Moger Date: Tue, 1 Nov 2016 14:13:43 -0700 > This is an attempt to cleanup watchdog handlers. Right now, > kernel/watchdog.c implements both softlockup and hardlockup detectors. > Softlockup code is generic. Hardlockup code is arch specific. Some > architectures don't use hardlockup detectors. They use their own watchdog > detectors. To make both these combination work, we have numerous #ifdefs > in kernel/watchdog.c. > > We are trying here to make these handlers independent of each other. > Also provide an interface for architectures to implement their own > handlers. watchdog_nmi_enable and watchdog_nmi_disable will be defined > as weak such that architectures can override its definitions. > > Thanks to Don Zickus for his suggestions. > Here are our previous discussions > http://www.spinics.net/lists/sparclinux/msg16543.html > http://www.spinics.net/lists/sparclinux/msg16441.html This touches a bunch of generic code, only the third patch is sparc specific. Anyways have any plans to merge this via another tree or should I take it via sparc? If I take it via sparc I want some ACKs. Thanks.