MIME-Version: 1.0
In-Reply-To: <201611220657.ILcuKTUN%fengguang.wu@intel.com>
References: <1479765897-29992-3-git-send-email-joelaf@google.com> <201611220657.ILcuKTUN%fengguang.wu@intel.com>
From: Joel Fernandes <joelaf@google.com>
Date: Mon, 21 Nov 2016 14:59:45 -0800
Message-ID: <CAJWu+oqoKz3LSi3tBgVxXBeSwgL-fkM+bcZ6RVjViHt6USePMA@mail.gmail.com>
Subject: Re: [PATCH 2/2] trace: Add an option for boot clock as trace clock
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, LKML <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1995
Lines: 48

On Mon, Nov 21, 2016 at 2:48 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Joel,
>
> [auto build test ERROR on tip/timers/core]
> [also build test ERROR on v4.9-rc6 next-20161117]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes/timekeeping-Introduce-a-fast-boot-clock-derived-from-fast-monotonic-clock/20161122-063314
> config: i386-randconfig-x004-201647 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>>> kernel/trace/trace.c:1128:4: error: 'ktime_get_boot_fast_ns' undeclared here (not in a function)
>      { ktime_get_boot_fast_ns, "boot",  1 },


Looks like I didn't have enough coffee today. I did test the patches
so this is rather strange, I must have missed the header export while
respinning from another tree. I will fix this, respin and post another
version later while waiting meanwhile for any other comments (and
addressing Steven's documentation comment).

Thanks,
Joel


>        ^~~~~~~~~~~~~~~~~~~~~~
>
> vim +/ktime_get_boot_fast_ns +1128 kernel/trace/trace.c
>
>   1122          { trace_clock_global,           "global",       1 },
>   1123          { trace_clock_counter,          "counter",      0 },
>   1124          { trace_clock_jiffies,          "uptime",       0 },
>   1125          { trace_clock,                  "perf",         1 },
>   1126          { ktime_get_mono_fast_ns,       "mono",         1 },
>   1127          { ktime_get_raw_fast_ns,        "mono_raw",     1 },
>> 1128          { ktime_get_boot_fast_ns,       "boot",         1 },
>   1129          ARCH_TRACE_CLOCKS
>   1130  };
>   1131
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation