Subject: Re: [PATCH] ARM: dts: exynos: remove the cd-gpios property for eMMC of
 odroid-xu3/4
To: Krzysztof Kozlowski <krzk@kernel.org>
References: <20161121071032.10183-1-jh80.chung@samsung.com>
 <CGME20161121170629epcas3p4ef4f3b98d44d31f456d75c33715f6b4a@epcas3p4.samsung.com>
 <20161121170605.GA8181@kozik-lap>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, kgene@kernel.org, cw00.choi@samsung.com,
        robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com,
        will.deacon@arm.com, m.szyprowski@samsung.com, a.hajda@samsung.com,
        jy0922.shim@samsung.com
From: Jaehoon Chung <jh80.chung@samsung.com>
Message-id: <9ecce088-b91d-d51a-5a19-33476961d2ea@samsung.com>
Date: Tue, 22 Nov 2016 10:24:21 +0900
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-version: 1.0
In-reply-to: <20161121170605.GA8181@kozik-lap>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1671
Lines: 59

On 11/22/2016 02:06 AM, Krzysztof Kozlowski wrote:
> On Mon, Nov 21, 2016 at 04:10:32PM +0900, Jaehoon Chung wrote:
>> Odroid-xu3/4 didn't need to use the cd-gpios for detecting card.
>> Because Host controller has the CDETECT register through SDx_CDN line.
>> Host controller can know whether card is inserted or not with this
>> register.
>>
>> When i have checked the Odroid-xu3/4, they are using CDETECT register.
>> (Not using exteranl cd-gpio.)
> 
> Makes sense. Just one question: the sd0_cd pinctrl setting should stay,
> right?

Right, It needs to use SD0_CD function.
I have tested on Odroid-XU3/XU4.

Tested with the below cases.

1) On boot with SD-card (without eMMC)
- Inserted eMMC : Detected
- Removed eMMC : Detected

2) On boot with Sd-card (with eMMC)
- Detected

3) On boot with eMMC 
- Detected

Best Regards,
Jaehoon Chung

> 
> Best regards,
> Krzysztof
> 
>> Fixes: fb1aeedb61ad ("ARM: dts: add mmc detect gpio for exynos5422-odroidxu3")
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 9e63328..05b9afdd 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -510,7 +510,6 @@
>>  &mmc_0 {
>>  	status = "okay";
>>  	mmc-pwrseq = <&emmc_pwrseq>;
>> -	cd-gpios = <&gpc0 2 GPIO_ACTIVE_LOW>;
>>  	card-detect-delay = <200>;
>>  	samsung,dw-mshc-ciu-div = <3>;
>>  	samsung,dw-mshc-sdr-timing = <0 4>;
>> -- 
>> 2.10.1
>>
> 
> 
>