Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754810AbcKVCPM (ORCPT ); Mon, 21 Nov 2016 21:15:12 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35693 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754404AbcKVCPL (ORCPT ); Mon, 21 Nov 2016 21:15:11 -0500 Date: Mon, 21 Nov 2016 18:15:07 -0800 From: Brian Norris To: Caesar Wang Cc: Caesar Wang , Zhang Rui , Eduardo Valentin , Heiko Stuebner , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Barber , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Message-ID: <20161122021506.GA103691@google.com> References: <1479513177-81504-1-git-send-email-briannorris@chromium.org> <1479513177-81504-2-git-send-email-briannorris@chromium.org> <378ade3d-a980-58e4-5253-c16702c74bf3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <378ade3d-a980-58e4-5253-c16702c74bf3@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 24 On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote: > CHECK: Alignment should match open parenthesis > #428: FILE: drivers/thermal/rockchip_thermal.c:428: > + pr_err("%s: invalid temperature, temp=%d error=%d\n", > + __func__, temp, error); > > CHECK: Alignment should match open parenthesis > #480: FILE: drivers/thermal/rockchip_thermal.c:480: > + pr_err("%s: invalid conversion table, mode=%d\n", > + __func__, table->mode); What patch are you checking? I ran mine through checkpatch, and there are no problems. Did you perhaps mangle the tabs into spaces when you saved the patch? > I'm ready to resend all rockchip thermal patches. (contain them) I see no reason to resend so far; the only criticism was on the 1st patch (a non-critical patch to the core thermal code; the others are relatively independent, as long as you don't care that I'm adding another error return without fixing up the broken CONFIG_THERMAL_EMULATION support). Brian