Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755100AbcKVDXx (ORCPT ); Mon, 21 Nov 2016 22:23:53 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:39980 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755028AbcKVDXv (ORCPT ); Mon, 21 Nov 2016 22:23:51 -0500 Subject: Re: [RFC][PATCH 3/3] usb: dwc2: Make sure we disconnect the gadget state To: John Stultz , lkml References: <1479246456-21652-1-git-send-email-john.stultz@linaro.org> <1479246456-21652-4-git-send-email-john.stultz@linaro.org> CC: Wei Xu , Guodong Xu , "Amit Pundir" , Rob Herring , John Youn , Douglas Anderson , Chen Yu , Felipe Balbi , "Greg Kroah-Hartman" , "linux-usb@vger.kernel.org" From: John Youn Message-ID: <1a2e8d57-610c-e869-36b8-cdece0c4252e@synopsys.com> Date: Mon, 21 Nov 2016 19:23:20 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479246456-21652-4-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.138.185] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2606 Lines: 69 On 11/15/2016 1:47 PM, John Stultz wrote: > I had seen some odd behavior with HiKey's usb-gadget interface > that I finally seemed to have chased down. Basically every other > time I pluged in the OTG port, the gadget interface would > properly initialize. The other times, I'd get a big WARN_ON > in dwc2_hsotg_init_fifo() about the fifo_map not being clear. Hi, The fifo_map could end up not being clear when disconnect is never sent to the UDC framework. That unsets the configuration and the endpoints get disabled, which clears the FIFO map. Looks like the problem happens when going from A-device to B-device. If you come up as an A-Device, the gadget wouldn't have been configured so it shouldn't warn going A->B. If you go B->A, you will get a session end detected, which triggers the udc disconnect. Then A->B should not warn here either. Can you determine why this doesn't happen on your system? It sounds like there might be some race condition that we need to identify. If you can provide logs with DEBUG enabled that would be helpful too. Regards, John > > Ends up if we don't disconnect the gadget state, the fifo-map > doesn't get cleared properly, which causes WARN_ON messages and > also results in the device not properly being setup as a gadget > every other time the OTG port is connected. > > So this patch adds a call to dwc2_hsotg_disconnect() in the > reset path so the state is properly cleared. > > With it, the gadget interface initializes properly on every > plug in. > > Cc: Wei Xu > Cc: Guodong Xu > Cc: Amit Pundir > Cc: Rob Herring > Cc: John Youn > Cc: Douglas Anderson > Cc: Chen Yu > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Signed-off-by: John Stultz > --- > drivers/usb/dwc2/hcd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > index 8c980fd..d2557b7 100644 > --- a/drivers/usb/dwc2/hcd.c > +++ b/drivers/usb/dwc2/hcd.c > @@ -3228,6 +3228,7 @@ static void dwc2_conn_id_status_change(struct work_struct *work) > dwc2_core_init(hsotg, false); > dwc2_enable_global_interrupts(hsotg); > spin_lock_irqsave(&hsotg->lock, flags); > + dwc2_hsotg_disconnect(hsotg); > dwc2_hsotg_core_init_disconnected(hsotg, false); > spin_unlock_irqrestore(&hsotg->lock, flags); > dwc2_hsotg_core_connect(hsotg); >