Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153AbcKVDkU (ORCPT ); Mon, 21 Nov 2016 22:40:20 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50890 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754895AbcKVDkS (ORCPT ); Mon, 21 Nov 2016 22:40:18 -0500 To: Juergen Gross Cc: Quentin Lambert , Boris Ostrovsky , David Vrabel , "James E.J. Bottomley" , "Martin K. Petersen" , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] xen-scsifront: Add a missing call to kfree From: "Martin K. Petersen" Organization: Oracle Corporation References: <20161119182256.9081-1-lambert.quentin@gmail.com> <1320a162-dc36-5833-a746-367134dae5e7@suse.com> Date: Mon, 21 Nov 2016 22:40:00 -0500 In-Reply-To: <1320a162-dc36-5833-a746-367134dae5e7@suse.com> (Juergen Gross's message of "Mon, 21 Nov 2016 07:01:36 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 21 >>>>> "Juergen" == Juergen Gross writes: Juergen, Juergen> On 19/11/16 19:22, Quentin Lambert wrote: >> Most error branches following the call to kmalloc contain a call to >> kfree. This patch add these calls where they are missing. >> >> This issue was found with Hector. >> >> Signed-off-by: Quentin Lambert Juergen> Nice catch. I think this will need some more work, I'll do a Juergen> follow-on patch. Juergen> Reviewed-by: Juergen Gross Are you taking this patch through the Xen tree or should I queue it up? -- Martin K. Petersen Oracle Linux Engineering