Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbcKVDl1 (ORCPT ); Mon, 21 Nov 2016 22:41:27 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48469 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754957AbcKVDlZ (ORCPT ); Mon, 21 Nov 2016 22:41:25 -0500 To: Bjorn Andersson Cc: Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" , Subhash Jadavani , Yaniv Gardi , Vivek Gautam , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] ufs: qcom: Properly clear hba priv on failure From: "Martin K. Petersen" Organization: Oracle Corporation References: <1479623691-7612-1-git-send-email-bjorn.andersson@linaro.org> Date: Mon, 21 Nov 2016 22:41:16 -0500 In-Reply-To: <1479623691-7612-1-git-send-email-bjorn.andersson@linaro.org> (Bjorn Andersson's message of "Sat, 19 Nov 2016 22:34:51 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 407 Lines: 11 >>>>> "Bjorn" == Bjorn Andersson writes: Bjorn> ufs_qcom_init() sets the hba priv data before attempting to Bjorn> acquire the phy handle, so make sure to clear this in the case of Bjorn> an error. Failing to do this will make ufs_qcom_setup_clocks() Bjorn> operate on the uninitalized host object. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering