Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755324AbcKVH5X (ORCPT ); Tue, 22 Nov 2016 02:57:23 -0500 Received: from mga05.intel.com ([192.55.52.43]:54408 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755283AbcKVH5V (ORCPT ); Tue, 22 Nov 2016 02:57:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,680,1473145200"; d="scan'208";a="904239596" Message-ID: <1479801436.2360.26.camel@intel.com> Subject: Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages From: Zhang Rui To: Caesar Wang , Caesar Wang , Brian Norris , Eduardo Valentin Cc: Heiko Stuebner , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Barber , linux-rockchip@lists.infradead.org Date: Tue, 22 Nov 2016 15:57:16 +0800 In-Reply-To: <378ade3d-a980-58e4-5253-c16702c74bf3@gmail.com> References: <1479513177-81504-1-git-send-email-briannorris@chromium.org> <1479513177-81504-2-git-send-email-briannorris@chromium.org> <378ade3d-a980-58e4-5253-c16702c74bf3@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3043 Lines: 87 On Tue, 2016-11-22 at 09:51 +0800, Caesar Wang wrote: > 在 2016年11月19日 11:31, Caesar Wang 写道: > > > > Brian, > > > > 在 2016年11月19日 07:52, Brian Norris 写道: > > > > > > These error messages don't give much information about what went > > > wrong. > > > It would be nice, for one, to see what invalid temperature was > > > being > > > requested when conversion fails. It's also good to return an > > > error when > > > we can't handle a conversion properly. > > > > > > While we're at it, fix the grammar too. > > > > > > Signed-off-by: Brian Norris > > > --- > > > Note: it'd probably be even nicer to know which sensor this was, > > > but  > > > we've > > > kinda abstracted that one away by this point... > > > > > >   drivers/thermal/rockchip_thermal.c | 7 +++++-- > > >   1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/thermal/rockchip_thermal.c  > > > b/drivers/thermal/rockchip_thermal.c > > > index e227a9f0acf7..35554d146b9d 100644 > > > --- a/drivers/thermal/rockchip_thermal.c > > > +++ b/drivers/thermal/rockchip_thermal.c > > > @@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(struct  > > > chip_tsadc_table table, > > >       } > > >     exit: > > > -    pr_err("Invalid the conversion, error=%d\n", error); > > > +    pr_err("%s: invalid temperature, temp=%d error=%d\n", > > > +        __func__, temp, error); > > I have do some similar for rockchip inside thermal driver.  Forget > > to  > > send for upstream. :( > > exit: > >     pr_err("%s: Invalid conversion table: code=%d, > > temperature=%d\n", > >            __func__, error, temp); > > > > > > > >       return error; > > >   } > > >   @@ -475,7 +476,9 @@ static int rk_tsadcv2_code_to_temp(struct  > > > chip_tsadc_table table, u32 code, > > >           } > > >           break; > > >       default: > > > -        pr_err("Invalid the conversion table\n"); > > > +        pr_err("%s: invalid conversion table, mode=%d\n", > > > +            __func__, table.mode); > > > +        return -EINVAL; > CHECK: Alignment should match open parenthesis > #428: FILE: drivers/thermal/rockchip_thermal.c:428: > +    pr_err("%s: invalid temperature, temp=%d error=%d\n", > +        __func__, temp, error); > > CHECK: Alignment should match open parenthesis > #480: FILE: drivers/thermal/rockchip_thermal.c:480: > +        pr_err("%s: invalid conversion table, mode=%d\n", > +            __func__, table->mode); > > > I'm ready to resend all rockchip thermal patches. (contain them) > so I will ignore patch 2/3 and 3/3 for now and wait for your new patch set. thanks, rui > > > > > > > >       } > > >         /* > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip