From: <Wenyou.Yang@microchip.com>
To: <alexandre.belloni@free-electrons.com>
CC: <nicolas.ferre@atmel.com>, <linux@arm.linux.org.uk>,
        <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v3] ARM: at91/dt: add dts file for sama5d36ek CMP board
Thread-Topic: [PATCH v3] ARM: at91/dt: add dts file for sama5d36ek CMP board
Thread-Index: AQHSQ7ZGp28eZr144Eq6fCs2aSuViqDj7c0AgADK/LA=
Date: Tue, 22 Nov 2016 09:11:43 +0000
Message-ID: <F9F4555C4E01D7469D37975B62D0EFBB44DB0B@CHN-SV-EXMX07.mchp-main.com>
References: <1479705283-3052-1-git-send-email-wenyou.yang@atmel.com>
 <20161121140248.utlir6krokjeeobi@piout.net>
In-Reply-To: <20161121140248.utlir6krokjeeobi@piout.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2969
Lines: 78


> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: 2016??11??21?? 22:03
> To: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>; Russell King
> <linux@arm.linux.org.uk>; Rob Herring <robh+dt@kernel.org>; Pawel Moll
> <pawel.moll@arm.com>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell
> <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; linux-
> kernel@vger.kernel.org; Wenyou Yang - A41535
> <Wenyou.Yang@microchip.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v3] ARM: at91/dt: add dts file for sama5d36ek CMP board
> 
> Hi,
> 
> I fixed it up this time but please use the proper subject prefix next time (ARM: dts:
> at91:).

Thank you.

I keep it in mind.

> 
> On 21/11/2016 at 13:14:42 +0800, Wenyou Yang wrote :
> > The sama5d36ek CMP board is the variant of sama5d3xek board.
> > It is equipped with the low-power DDR2 SDRAM, PMIC ACT8865 and some
> > power rail. Its main purpose is used to measure the power consumption.
> > The difference of the sama5d36ek CMP dts from sama5d36ek dts is listed
> > as below.
> >  1. The USB host nodes are removed, that is, the USB host is disabled.
> >  2. The gpio_keys node is added to wake up from the sleep.
> >  3. The LCD isn't supported due to the pins for LCD are conflicted
> >     with gpio_keys.
> >  4. The adc0 node support the pinctrl sleep state to fix the over
> >     consumption on VDDANA.
> >
> > As said in errata, "When the USB host ports are used in high speed
> > mode (EHCI), it is not possible to suspend the ports if no device is
> > attached on each port. This leads to increased power consumption even
> > if the system is in a low power mode." That is why the the USB host is
> > disabled.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> > Changes in v3:
> >  - Use a dual license scheme for DT files.
> >  - Use the proper model name and the compatible string to reflect
> >    the nature of this new "CMP" board.
> >  - Change name of wakeup property to "wakeup-source".
> >  - Remove unnecessary comments.
> >  - Remove bootargs.
> >
> > Changes in v2:
> >  - Add the pinctrl sleep state for adc0 node to fix the over
> >    consumption on VDDANA.
> >  - Improve the commit log.
> >
> >  arch/arm/boot/dts/sama5d36ek_cmp.dts  |  87 ++++++++++
> > arch/arm/boot/dts/sama5d3xcm_cmp.dtsi | 201 +++++++++++++++++++++++
> > arch/arm/boot/dts/sama5d3xmb_cmp.dtsi | 301
> > ++++++++++++++++++++++++++++++++++
> >  3 files changed, 589 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sama5d36ek_cmp.dts
> >  create mode 100644 arch/arm/boot/dts/sama5d3xcm_cmp.dtsi
> >  create mode 100644 arch/arm/boot/dts/sama5d3xmb_cmp.dtsi
> >
> Applied, thanks.
> 
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Best Regards,
Wenyou Yang