Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932550AbcKVJtL (ORCPT ); Tue, 22 Nov 2016 04:49:11 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:18677 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932390AbcKVJtI (ORCPT ); Tue, 22 Nov 2016 04:49:08 -0500 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 22 Nov 2016 01:49:06 -0800 Message-ID: <5834109E.60006@nvidia.com> Date: Tue, 22 Nov 2016 15:02:14 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Joe Perches , Jon Hunter , , , , , CC: , , , , , Subject: Re: [PATCH V2 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads References: <1478696782-11657-1-git-send-email-ldewangan@nvidia.com> <1478696782-11657-3-git-send-email-ldewangan@nvidia.com> <29e19381-9250-3059-b083-49e8ab56ea7f@nvidia.com> <5833FE99.2020004@nvidia.com> <1479807957.1942.9.camel@perches.com> In-Reply-To: <1479807957.1942.9.camel@perches.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 31 On Tuesday 22 November 2016 03:15 PM, Joe Perches wrote: > On Tue, 2016-11-22 at 13:45 +0530, Laxman Dewangan wrote: >> On Tuesday 22 November 2016 02:31 AM, Jon Hunter wrote: >>> On 09/11/16 13:06, Laxman Dewangan wrote: >>> + _entry_(32, "uart", UART, true, "vddio-uart"), \ >>> + _entry_(33, "usb0", USB0, true, NULL), \ >>> + _entry_(34, "usb1", USB1, true, NULL), \ >>> + _entry_(35, "usb2", USB2, true, NULL), \ >>> + _entry_(36, "usb3", USB3, true, NULL), \ >>> + _entry_(37, "usb-bias", USB_BIAS, true, NULL) >>> Can you also fix these checkpatch errors ... >>> >>> ERROR: Macros with complex values should be enclosed in parentheses >>> #424: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:350: >>> >>> ERROR: Macros with complex values should be enclosed in parentheses >>> #456: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:382: >> I can fix this but will still have the error as: >> >> CHECK: Macro argument reuse '_entry_' - possible side-effects? >> #425: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:425: >> >> >> And there is no better way to fix this. > It's a stupid little script, feel free to ignore it. And when I tried to add the parenthesis, it failed in compilation. So in this case, we just need to ignore the error of Macros with complex values should be enclosed in parentheses