From: "Y.T. Tang" <yuantian.tang@nxp.com>
To: Scott Wood <oss@buserror.net>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>
CC: "sboyd@codeaurora.org" <sboyd@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Scott Wood <scott.wood@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] clk: qoriq: added ls1012a clock configuration
Thread-Topic: [PATCH] clk: qoriq: added ls1012a clock configuration
Thread-Index: AQHSP9BHYNrOZA8r4kGzYMxeqhQj6KDbLOQAgAmFlnA=
Date: Tue, 22 Nov 2016 08:20:00 +0000
Message-ID: <DB6PR0402MB28371BAAD862417B8AC8AED4F0B40@DB6PR0402MB2837.eurprd04.prod.outlook.com>
References: <1479275900-42365-1-git-send-email-yuantian.tang@nxp.com>
 <1479279262.21746.40.camel@buserror.net>
In-Reply-To: <1479279262.21746.40.camel@buserror.net>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2016 08:20:00.5672
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1934
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAM9rfMh004932
Content-Length: 2718
Lines: 89

Hi Scott,

> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Wednesday, November 16, 2016 2:54 PM
> To: Y.T. Tang <yuantian.tang@nxp.com>; mturquette@baylibre.com
> Cc: sboyd@codeaurora.org; linux-kernel@vger.kernel.org; Scott Wood
> <scott.wood@nxp.com>; linux-clk@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH] clk: qoriq: added ls1012a clock configuration
> 
> On Wed, 2016-11-16 at 13:58 +0800, yuantian.tang@nxp.com wrote:
> > From: Tang Yuantian <Yuantian.Tang@nxp.com>
> >
> > Added ls1012a clock configuation information.
> 
> Do we really need the same line in the changelog twice?
> 
> >
> > Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> > ---
> >  drivers/clk/clk-qoriq.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 1bece0f..563d874 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -202,6 +202,14 @@ static const struct clockgen_muxinfo ls1021a_cmux
> = {
> >  	}
> >  };
> >
> > +static const struct clockgen_muxinfo ls1012a_cmux = {
> > +	{
> > +		[0] = { CLKSEL_VALID, CGA_PLL1, PLL_DIV1 },
> > +		{},
> > +		[2] = { CLKSEL_VALID, CGA_PLL1, PLL_DIV2 },
> > +	}
> > +};
> > +
> 
> Based on the "ls1021a_cmux" in the context it looks like this patch is
> intended to apply on top
> of https://patchwork.kernel.org/patch/8923541/ but I don't see any mention
> of that.
> 
I saw this patch had been merged already.

Regards,
Yuantian

> >  static const struct clockgen_muxinfo t1040_cmux = {
> >  	{
> >  		[0] = { CLKSEL_VALID, CGA_PLL1, PLL_DIV1 }, @@ -482,6
> +490,16 @@
> > static const struct clockgen_chipinfo chipinfo[] = {
> >  		.pll_mask = 0x03,
> >  	},
> >  	{
> > +		.compat = "fsl,ls1012a-clockgen",
> > +		.cmux_groups = {
> > +			&ls1012a_cmux
> > +		},
> > +		.cmux_to_group = {
> > +			0, -1
> > +		},
> > +		.pll_mask = 0x03,
> > +	},
> > +	{
> >  		.compat = "fsl,ls1043a-clockgen",
> >  		.init_periph = t2080_init_periph,
> >  		.cmux_groups = {
> > @@ -1284,6 +1302,7 @@ CLK_OF_DECLARE(qoriq_clockgen_2,
> > "fsl,qoriq-clockgen- 2.0", clockgen_init);
> >  CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen",
> > clockgen_init);
> >  CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen",
> > clockgen_init);
> >  CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen",
> > clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen",
> > clockgen_init);
> 
> Please keep these lists of chips sorted (or as close as you can in the case of
> the cmux structs which already have some sorting issues).
> 
> -Scott