Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932914AbcKVKgb (ORCPT ); Tue, 22 Nov 2016 05:36:31 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:46527 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932495AbcKVKga (ORCPT ); Tue, 22 Nov 2016 05:36:30 -0500 Subject: Re: [RESEND PATCH 1/3] ARM: davinci: da830: Handle vbus with a regulator To: Axel Haslam , , References: <20161121165349.29128-1-ahaslam@baylibre.com> <20161121165349.29128-2-ahaslam@baylibre.com> CC: , From: Sekhar Nori Message-ID: Date: Tue, 22 Nov 2016 16:05:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161121165349.29128-2-ahaslam@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 33 On Monday 21 November 2016 10:23 PM, Axel Haslam wrote: > static __init void da830_evm_usb_init(void) > { > @@ -145,23 +123,13 @@ static __init void da830_evm_usb_init(void) > return; > } > > - ret = gpio_request(ON_BD_USB_DRV, "ON_BD_USB_DRV"); > - if (ret) { > - pr_err("%s: failed to request GPIO for USB 1.1 port power control: %d\n", > - __func__, ret); > - return; > - } > - gpio_direction_output(ON_BD_USB_DRV, 0); > + gpiod_add_lookup_table(&usb11_gpios_table); > > - ret = gpio_request(ON_BD_USB_OVC, "ON_BD_USB_OVC"); > - if (ret) { > - pr_err("%s: failed to request GPIO for USB 1.1 port over-current indicator: %d\n", > - __func__, ret); > - return; > - } > - gpio_direction_input(ON_BD_USB_OVC); > + ret = platform_device_register(&da8xx_usb11_regulator); > + if (ret) > + pr_warn("fail to add ohci regulator\n"); Can you follow the same style as used in other error/warning messages in this function (adding a function name prefix, printing of error code). Thanks, Sekhar