From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
        linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
        viro@zeniv.linux.org.uk,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: commit 4dd1837d7589f468ed109556513f476e7a7f9121 breaks build
Date: Tue, 22 Nov 2016 12:11:41 +0100
Message-ID: <11556597.ehuL0N36ia@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161120172248.GW1041@n2100.armlinux.org.uk>
References: <58310EC6.4020402@math.uni-bielefeld.de> <alpine.LFD.2.20.1611201131300.1814@knanqh.ubzr> <20161120172248.GW1041@n2100.armlinux.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 984
Lines: 25

On Sunday, November 20, 2016 5:22:48 PM CET Russell King - ARM Linux wrote:
> - not touching:
>         arch/arm/lib/csumpartialcopy.S
>         arch/arm/lib/csumpartialcopygeneric.S
>         arch/arm/lib/csumpartialcopyuser.S
> 
> other than that, it's doing the same thing.
> 
> I think Arnd's changes to the csumpartial code are unnecessary, and
> yours is, although larger, puts the asm/export.h include in the right
> place.  So please drop yours into the patch system so we can move
> forward fixing some of the problems created during the last merge
> window.

Right, the csumpartialcopy*.S changes are no longer needed after
commit cc6acc11cad1 ("kbuild: be more careful about matching
preprocessed asm ___EXPORT_SYMBOL") solves the problem more
generally.

I've submitted a new version of my patch, now just adding the
one header file that is needed to get MODVERSIONS back working,
plus the second patch for mmiocpy/mmioset to partially revert
Al's original change.

	Arnd