Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263358AbTEJFHi (ORCPT ); Sat, 10 May 2003 01:07:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263654AbTEJFHi (ORCPT ); Sat, 10 May 2003 01:07:38 -0400 Received: from phoenix.infradead.org ([195.224.96.167]:34322 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S263358AbTEJFHh (ORCPT ); Sat, 10 May 2003 01:07:37 -0400 Date: Sat, 10 May 2003 06:20:16 +0100 From: Christoph Hellwig To: chas williams Cc: Francois Romieu , "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!) Message-ID: <20030510062015.A21408@infradead.org> Mail-Followup-To: Christoph Hellwig , chas williams , Francois Romieu , "David S. Miller" , linux-kernel@vger.kernel.org References: <20030510000222.A10796@electric-eye.fr.zoreil.com> <200305092339.h49NcYGi011242@locutus.cmf.nrl.navy.mil> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200305092339.h49NcYGi011242@locutus.cmf.nrl.navy.mil>; from chas@locutus.cmf.nrl.navy.mil on Fri, May 09, 2003 at 07:38:34PM -0400 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 16 On Fri, May 09, 2003 at 07:38:34PM -0400, chas williams wrote: > + > +init_one_failure: > + if (atm_dev) atm_dev_deregister(atm_dev); > + if (he_dev) kfree(he_dev); > + pci_disable_device(pci_dev); > + return err; kfree(NULL) if perfectly fine. Also please untangle all this if statements to two separate lines. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/