Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755329AbcKVMX5 (ORCPT ); Tue, 22 Nov 2016 07:23:57 -0500 Received: from mga05.intel.com ([192.55.52.43]:9196 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbcKVMX4 (ORCPT ); Tue, 22 Nov 2016 07:23:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,680,1473145200"; d="asc'?scan'208";a="904310127" From: Felipe Balbi To: Stefan Wahren , John Youn , Vardan Mikayelyan , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param In-Reply-To: <1479677166-13114-6-git-send-email-stefan.wahren@i2se.com> References: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> <1479677166-13114-6-git-send-email-stefan.wahren@i2se.com> Date: Tue, 22 Nov 2016 14:23:04 +0200 Message-ID: <87lgwbr9ef.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1973 Lines: 54 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Stefan Wahren writes: > Since there is no parameter @value replace it with @legacy. > > Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") > Signed-off-by: Stefan Wahren > --- > drivers/usb/dwc2/params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index 11fe68a..10407cb 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -320,7 +320,7 @@ static void dwc2_set_core_param(void *param, u8 size,= u64 value) > * @size: The size of the core parameter in bytes, or 0 for bool. > * > * This function looks up @property and sets the @param to that value. > - * If the property doesn't exist it uses the passed-in @value. It will > + * If the property doesn't exist it uses the passed-in @legacy value. It= will This doesn't fix any bugs. Also, is @legacy a parameter? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlg0OKgACgkQzL64meEa mQYfyBAA0XOFfiFUXJa6wzwPIMJq2ap6QrfGwyyAHAMSLiSuyhO4FUFzemqyN9Tr xmffZ67VVvaVR8/fEfIvaaYAGEaigO5nQ/1LhU+F27M/OOsZoGLpvlIVIHDC+4z+ 0Ws8KLPBINVJ1Rn35Wj604iGmPnkn5m5FhxgarsyyqdiRibDALrad/d2JbD2j+E6 3fPDfSa5eu/xSUGuE63Uz2a/usK4FpVqNaHiH+oc/RWi7jufXRCtLYbWM36SmUdQ 5qx5H4Wtcb4G3H+04EFVgyBzM0aY4QW+8ZNUbw/Z8xJxsLZeJ9BnNwviqQFoNc0h JH02hv8M8CDGoCz/TO2bvBXjF53QvTYyesUHWCDUlGsGS+ZYV/XuF8aVzzbxLoCS OweZq0ajIod9a3kukk7ZNsNgw1f+bxLynELQyThtfM8YXPi+mnxO+chFbX0V6QiO RegJIGLkq02+yavyfRGCuZgv/+J1ZzwMbTlBjbJkk2gx9HNpXtrIi+7NNM4UYV6d uvn2HNmMNFGoDS6MsOWMrilR98Q3sBWvfi8w6rQ2XHDyKc7Ki1VFGNj9sWRMRr1t 7On3YSiXRyT/L4Oi7/s1LmUb2m7oTlER/JO7I5BNZ6ekutsc+dddRfsqCjbFUeTT DVyqXYI/zv2welWioplaAZ+1a2QqFhDZG8oFinBGCV1Kvqw4wwk= =9gZm -----END PGP SIGNATURE----- --=-=-=--