Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297AbcKVORG (ORCPT ); Tue, 22 Nov 2016 09:17:06 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:55634 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932960AbcKVORE (ORCPT ); Tue, 22 Nov 2016 09:17:04 -0500 Subject: Re: Synopsys Ethernet QoS Driver To: Lars Persson , Giuseppe CAVALLARO References: <1dbb6047-2bbb-4d56-2a62-ab65a0254844@synopsys.com> <20161119135654.GA14079@lnxartpec.se.axis.com> <1248f4ce-4859-10e6-fef9-342ea543f8d4@synopsys.com> <87c8a24b-0812-7850-cb3f-7be691bab432@st.com> <7c7798b5-8cd4-ba99-f526-22d3e06e05db@synopsys.com> CC: Joao Pinto , Rayagond Kokatanur , Rabin Vincent , mued dib , David Miller , Jeff Kirsher , "jiri@mellanox.com" , "saeedm@mellanox.com" , "idosch@mellanox.com" , netdev , "linux-kernel@vger.kernel.org" , "CARLOS.PALMINHA@synopsys.com" , =?UTF-8?Q?Andreas_Irest=c3=a5l?= , "alexandre.torgue@st.com" , "linux-arm-kernel@lists.infradead.org" From: Joao Pinto Message-ID: <2eefdb8f-7e87-6009-6e50-c536d4b95dd6@synopsys.com> Date: Tue, 22 Nov 2016 14:16:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <7c7798b5-8cd4-ba99-f526-22d3e06e05db@synopsys.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.109] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3194 Lines: 113 Hi Lars and Peppe, On 21-11-2016 16:11, Joao Pinto wrote: > On 21-11-2016 15:43, Lars Persson wrote: >> >> >>> 21 nov. 2016 kl. 16:06 skrev Joao Pinto : >>> >>>> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: >>>>> On 11/21/2016 2:28 PM, Lars Persson wrote: >>>>> >>>>> >>>>>> 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO : >>>>>> >>>>>> Hello Joao >>>>>> >>>>>>> On 11/21/2016 1:32 PM, Joao Pinto wrote: >>>>>>> Hello, >>>>>>> >>>>>>>>> On 21-11-2016 05:29, Rayagond Kokatanur wrote: >>>>>>>>>> On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: >>>>>>>>>> On Fri, Nov 18, 2016 at 02:20:27PM +0000, Joao Pinto wrote: >>>>>>>>>> For now we are interesting in improving the synopsys QoS driver under >>>>>>>>>> /nect/ethernet/synopsys. For now the driver structure consists of a >>>>>>>>>> single file >>>>>>>>>> called dwc_eth_qos.c, containing synopsys ethernet qos common ops and > snip (...) >>>>>> >>>>>> Peppe >>>>>> >>>>> >>>>> Hello Joao and others, >>>>> >>> >>> Hi Lars, >>> >>>>> As the maintainer of dwc_eth_qos.c I prefer also that we put efforts on the >>>>> most mature driver, the stmmac. >>>>> >>>>> I hope that the code can migrate into an ethernet/synopsys folder to keep the >>>>> convention of naming the folder after the vendor. This makes it easy for >>>>> others to find the driver. >>>>> >>>>> The dwc_eth_qos.c will eventually be removed and its DT binding interface can >>>>> then be implemented in the stmmac driver. >>> >>> So your ideia is to pick the ethernet/stmmac and rename it to ethernet/synopsys >>> and try to improve the structure and add the missing QoS features to it? >> >> Indeed this is what I prefer. > > Ok, it makes sense. > Just for curiosity the target setup is the following: > https://www.youtube.com/watch?v=8V-LB5y2Cos > but instead of using internal drivers, we desire to use mainline drivers only. > > Thanks! Regarding this subject, I am thinking of making the following adaption: a) delete ethernet/synopsys b) rename ethernet/stmicro/stmmac to ethernet/synopsys and send you a patch for you to evaluate. Both agree with the approach? To have a new work base would be important, because I will add to the "new" structure some missing QoS features like Multichannel support, CBS and later TSN. Thanks. > >> >>> >>>> >>>> Thanks Lars, I will be happy to support all you on this transition >>>> and I agree on renaming all. >>>> >>>> peppe >>>> >>>> >>>>> - Lars >>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> (See http://lists.openwall.net/netdev/2016/02/29/127) >>>>>>>>> >>>>>>>>> The former only supports 4.x of the hardware. >>>>>>>>> >>>>>>>>> The later supports 4.x and 3.x and already has a platform glue driver >>>>>>>>> with support for several platforms, a PCI glue driver, and a core driver >>>>>>>>> with several features not present in the former (for example: TX/RX >>>>>>>>> interrupt coalescing, EEE, PTP). >>>>>>>>> >>>>>>>>> Have you evaluated both drivers? Why have you decided to work on the >>>>>>>>> former rather than the latter? >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >