Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754833AbcKVO6R (ORCPT ); Tue, 22 Nov 2016 09:58:17 -0500 Received: from smtprelay0152.hostedemail.com ([216.40.44.152]:52805 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753274AbcKVO6Q (ORCPT ); Tue, 22 Nov 2016 09:58:16 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3870:3871:3873:3874:4321:5007:6119:7903:10004:10400:10848:11232:11658:11914:12555:12740:12760:13069:13311:13357:13439:14181:14659:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: gold81_64f41fb6a9934 X-Filterd-Recvd-Size: 1384 Message-ID: <1479826691.1942.11.camel@perches.com> Subject: Re: [PATCH 1/6] x86/efi: Allow invocation of arbitrary runtime services From: Joe Perches To: David Howells , Lukas Wunner Cc: linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 22 Nov 2016 06:58:11 -0800 In-Reply-To: <27422.1479824220@warthog.procyon.org.uk> References: <20161122102018.GB1552@wunner.de> <20161117123731.GA11573@wunner.de> <147977469914.6360.17194649697208113702.stgit@warthog.procyon.org.uk> <27422.1479824220@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 375 Lines: 11 On Tue, 2016-11-22 at 14:17 +0000, David Howells wrote: > Lukas Wunner wrote: > > > Small nit, checkpatch usually complains that this should be written as > > 12-character SHA-1 followed by the commit subject, i.e. > > > > 0a637ee61247 ("x86/efi: Allow invocation of arbitrary boot services") > > In this case, checkpatch is wrong. Why do you think so?