Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755367AbcKVPAG (ORCPT ); Tue, 22 Nov 2016 10:00:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49423 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbcKVPAE (ORCPT ); Tue, 22 Nov 2016 10:00:04 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20161122104401.GC1552@wunner.de> References: <20161122104401.GC1552@wunner.de> <20161117123731.GA11573@wunner.de> <147977472115.6360.13015228230799369019.stgit@warthog.procyon.org.uk> To: Lukas Wunner Cc: dhowells@redhat.com, Matthew Garrett , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 4/6] efi: Get the secure boot status MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25370.1479826321.1@warthog.procyon.org.uk> Date: Tue, 22 Nov 2016 14:52:01 +0000 Message-ID: <25371.1479826321@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 22 Nov 2016 14:52:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 308 Lines: 9 Lukas Wunner wrote: > You dropped the efi_system_table_t *sys_table_arg argument but this > isn't defined anywhere as a static global. It seems to me that passing this value in on x86 is probably a bad idea as it's not mixed-mode safe. Should I just pass NULL there in that case? David