Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932549AbcKVPNo (ORCPT ); Tue, 22 Nov 2016 10:13:44 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:33886 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755961AbcKVPNn (ORCPT ); Tue, 22 Nov 2016 10:13:43 -0500 From: Gregory CLEMENT To: Arnd Bergmann Cc: "David S. Miller" , Florian Fainelli , Marcin Wojtas , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] marvell: mark mvneta and mvpp2 32-bit only References: <20161122142136.1690096-1-arnd@arndb.de> Date: Tue, 22 Nov 2016 16:13:40 +0100 In-Reply-To: <20161122142136.1690096-1-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 22 Nov 2016 15:21:22 +0100") Message-ID: <87twazo8d7.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2377 Lines: 64 Hi Arnd, On mar., nov. 22 2016, Arnd Bergmann wrote: > Both of these drivers won't work on 64-bit architectures unless they > are redesigned, since they store a virtual address pointer in a 32-bit > field of the descriptors: > > drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_construct': > drivers/net/ethernet/marvell/mvneta_bm.c:103:16: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_vlan_init': > drivers/net/ethernet/marvell/mvpp2.c:2563:32: error: large integer implicitly truncated to unsigned type [-Werror=overflow] > > This limits the COMPILE_TEST option for the two drivers again to > only build them on 32-bit. This seems nicer than shutting up the > warnings, in case we ever actually want to use them on 64-bit, > as the warnings indicate which parts of the driver are currently Actually we are using these drivers on 64-bits so obviously there are not 32 bits only! For mvneta currently we do not use BM on the 64-bits version. I agree that there is a problem with mvneta_bm.c when building in 64-bits but it should not prevent us to use the mvneta driver. Gregory > broken there. > > Fixes: a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ethernet/marvell/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig > index d74d4e6f0b34..66fd9dbb2ca7 100644 > --- a/drivers/net/ethernet/marvell/Kconfig > +++ b/drivers/net/ethernet/marvell/Kconfig > @@ -58,6 +58,7 @@ config MVNETA > tristate "Marvell Armada 370/38x/XP network interface support" > depends on PLAT_ORION || COMPILE_TEST > depends on HAS_DMA > + depends on !64BIT > select MVMDIO > select FIXED_PHY > ---help--- > @@ -81,6 +82,7 @@ config MVPP2 > tristate "Marvell Armada 375 network interface support" > depends on MACH_ARMADA_375 || COMPILE_TEST > depends on HAS_DMA > + depends on !64BIT > select MVMDIO > ---help--- > This driver supports the network interface units in the > -- > 2.9.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com