Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756118AbcKVPtf (ORCPT ); Tue, 22 Nov 2016 10:49:35 -0500 Received: from mail-yw0-f178.google.com ([209.85.161.178]:34007 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756098AbcKVPtd (ORCPT ); Tue, 22 Nov 2016 10:49:33 -0500 Date: Tue, 22 Nov 2016 10:49:23 -0500 (EST) From: Martin Brandenburg To: Christophe JAILLET cc: hubcap@omnibond.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] orangefs: Axe some dead code In-Reply-To: <20161121221702.6438-1-christophe.jaillet@wanadoo.fr> Message-ID: References: <20161121221702.6438-1-christophe.jaillet@wanadoo.fr> User-Agent: Alpine 2.20 (BSO 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 41 On Mon, 21 Nov 2016, Christophe JAILLET wrote: > The "perf_counter_reset" case has already been handled above. > Moreover "ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE" is not a really > consistent. > It is likely that this (dead) code is a cut and paste left over. That's exactly what this is. Reviewed-by: Martin Brandenburg > > Signed-off-by: Christophe JAILLET > --- > fs/orangefs/orangefs-sysfs.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/fs/orangefs/orangefs-sysfs.c b/fs/orangefs/orangefs-sysfs.c > index a799546a67f7..084954448f18 100644 > --- a/fs/orangefs/orangefs-sysfs.c > +++ b/fs/orangefs/orangefs-sysfs.c > @@ -609,15 +609,6 @@ static ssize_t sysfs_service_op_store(struct kobject *kobj, > new_op->upcall.req.param.u.value32[0] = val1; > new_op->upcall.req.param.u.value32[1] = val2; > goto value_set; > - } else if (!strcmp(attr->attr.name, > - "perf_counter_reset")) { > - if ((val > 0)) { > - new_op->upcall.req.param.op = > - ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE; > - } else { > - rc = 0; > - goto out; > - } > } > > } else if (!strcmp(kobj->name, ACACHE_KOBJ_ID)) { > -- > 2.9.3 > >