Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933068AbcKVPy5 (ORCPT ); Tue, 22 Nov 2016 10:54:57 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:45938 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754078AbcKVPyw (ORCPT ); Tue, 22 Nov 2016 10:54:52 -0500 Subject: Re: [PATCH 00/12] block: cleanup direct access to bvec table To: Ming Lei , References: <1478865957-25252-1-git-send-email-tom.leiming@gmail.com> CC: , , "Christoph Hellwig" , Adrian Hunter , Coly Li , "open list:DEVICE-MAPPER (LVM)" , "open list:DRBD DRIVER" , Eric Wheeler , Guoqing Jiang , Hannes Reinecke , Jiri Kosina , Johannes Thumshirn , Keith Busch , Kent Overstreet , "open list:BCACHE (BLOCK LAYER CACHE)" , "open list:NVM EXPRESS TARGET DRIVER" , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" , "open list:TARGET SUBSYSTEM" , "open list:LogFS" , "Mike Christie" , Mike Snitzer , "Rasmus Villemoes" , "open list:TARGET SUBSYSTEM" , Yijing Wang , "Zheng Liu" From: Jens Axboe Message-ID: <167c2511-349f-a8e6-17d1-f7ce438b2f14@fb.com> Date: Tue, 22 Nov 2016 08:53:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478865957-25252-1-git-send-email-tom.leiming@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR20CA0023.namprd20.prod.outlook.com (10.165.25.36) To DM5PR15MB1194.namprd15.prod.outlook.com (10.173.209.12) X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;2:KiszOKbwWUptWLNdOkC6hTr0WrAnYsRpNVgKS/iiL9zBTX2O7haL11x/TribhTjuWLOIELFrb4qF18dx70brojug7JIEjt/NDgx3x6H3VquITXN9buWcp9X68VGTj/Y4eCcufA6ypJLCbISTPJsvvVCL9f6IhkJqA7QAzRlpeK0=;3:J2okvcV0FZeCiM75adSE1pENfc7Ek4z4BDNw1A0IunMx2BGeTn/0VJpWqreikwps9/6rzpdKUcDcmIByUrEi/W3LY7+8xQBr6n23un6d8I69SqKjr6dl9BISlj1PztmP7hgg48YMtlQpgUHRFbswZJHyXiXv/c3TV51nQ5oeNzU=;25:J8ek670wJymBH2rkQ2RDCux2wU06CKs8UIbKwK/YAOPF1ZQuWuV0dl1iWD6vzodwWlDwhoXVP9rSL1b1DFP3rfG63BYNOr7RIg1AFI0ZFnGrb+B2MjXqmxRN11EbPwioEeoj4RKgrJr+ktcSmH1BhXrEGvA6vNBSdSLpm5tL0QCxFCzmhWUvZqkT140dxz5YumnxRbt66Aj7vTIFTXzh3NQPnCb7Oadr354ZbgiNmezuxKGlOdnP/StPrGBllrA54ztU2Eh7YsInF7zxYp4gmjMjPjE/OS9cDH5nKf0BwEOdGcfv7cofvwuUUEQsDSeOj4aktB3rQRHArX9T6NUH6jrGTEdYz0pBgR7CR4Fon7rNWDVTRGGh45aZ0ASwHmq0tfydD981GMETiPUM5YnXRYULxLHZpLW7EX4HDyRVb9f7CvM9Y0L6Zb7IuknwHmjUiqS/nHqsqXRCuVudqP9iBw== X-MS-Office365-Filtering-Correlation-Id: f5974492-e0f4-4065-af48-08d412efa595 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;31:6DRYiWpd0C90kFDK81bZK3TtCGhFuCTLg+zK5nyI0Jr0xG8ESz8ArvutSLS6NMzmAsPGWRSmsAk5YK3mTIj/eIK13LFcErwUw6b4Roi/J8vQFQP0EfT+IQwaLc6GLAK2DbvaKTYh4Iv32dS8KUZKks7QhR4fUURC/0yz/L8cICaWfqPTtLJ3sykdFm9yKIrrI5B8JCr6bmZI1R5YBuMxAq4sEf5RgVPnjAiK2Td1j/pOi2keqD9mbKU/s+AM0vNfhmUYOrgHdubN1Ke0ZZmsv3vg4aDLizYnFOxI0qn58+8=;20:HJV4IiQJ524I9OYtQ2rAITilY/FC6pkF/uPMeNtrvKDjRygntHaWvvxZjhrPQ8VrlNjALISwnOgRFjwnoTZvysc8ZuazawWYL+LX9aT+LqvtAVeqJFEu55YmZibFfcFGCLc0rC99kTG6O3+E1APkxgzmYdRATHcYi1hrrhhVBOZPAD64/kptNYBrbkly6+T1iLNRwlkvanvfudp5YLBGT4gcgBkBF4hh+ApiAEazDYxlLfSiOt/HBCKQSZj7hfIT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6045199)(6040307)(6060326)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(6061324)(6072148)(6042181);SRVR:DM5PR15MB1194;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1194; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;4:Baufcdr74RaIHRzQtlX3AJFjDA+WLybt52BpKGyP7Pu6dIXPShcTwnTtOx4Kck9ihZ664+CSwl6bbXdpguVN8qpYXRZ0t1/ZOZQMhhH9vtS5tHrGHziK4JBJ5TJRGA3cJNtQhFtS4CSQDUQ655dgGJn6jJ4BMQVA87hfv4lkt4wQFWttnF/EsvOFGQrOhHPH7rMBSxII2B1YOGem5egRWf3AfIORXLqgrhy0TTGNMgFs9pwCOsD+gEpEN9iZPxEgxvTw/Qks9ObPNClDLqS4/+IrL0I4nPwP3BJrhZMDSTpgmsVURjJ+friruMN3xFWULEAJoSY5zF7IoJxuBgfEjBTdnwdDZAdLSHTxjGcI9VGJaOCFlBwexI1N4KMaxuxHgyzABRiEJnOQbJVdIcMT5eYyZUsy0QpsxRPbfYIot65FtUlCrsKSxQrLy6KZ5cy48gtnj1LoDkf1Ki1PTJdAP3j0Afnt2b6yQ6MpZ/KIpW/6CyWSZw6lTNOEEWMoAxVYz/lYGQZbGcw2LNm4Sxs9GQ/C/2Jak3SxE9Brb9VtzlU= X-Forefront-PRVS: 0134AD334F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(377454003)(24454002)(189002)(7846002)(92566002)(33646002)(68736007)(64126003)(97736004)(4001350100001)(7736002)(305945005)(77096005)(23746002)(117156001)(8676002)(81156014)(2906002)(7416002)(5001770100001)(5660300001)(4326007)(83506001)(65826007)(81166006)(47776003)(189998001)(3846002)(65956001)(6116002)(31696002)(66066001)(36756003)(65806001)(2950100002)(50466002)(42186005)(31686004)(50986999)(105586002)(230700001)(101416001)(86362001)(229853002)(38730400001)(76176999)(106356001)(54356999);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1194;H:[192.168.1.129];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1194;23:7GvW8QS762qJRpUl4MQdH5D+aacHLddr+euFb?= =?Windows-1252?Q?xDCBsSEHA+cfjX03hYTLixTSwMqfu+vqDQthqi4j6r8MwYH5pju3ueCs?= =?Windows-1252?Q?rI/u3Jt+/HXPmdfVT14IqRJ5jYYrj5nHCRFFB2HuzWoxVPCmZN9Sm7c5?= =?Windows-1252?Q?kUoywf//SUux9lKZeKW/zg1z0hdDp/7NmBNwOzDdgn/ZGZE8mhdF9ig+?= =?Windows-1252?Q?hlL+6r06ZHNfv4l6xDOurVG7bpsTk4i9TdVXcx7fKpvON1/J2cQChr6h?= =?Windows-1252?Q?6PgMr8xx8GKyvM/E0YxiiAieXK6jE417zI9ghiQAptOJXKgKrdUQ7boT?= =?Windows-1252?Q?gg26Us/3zccekx6smAbcrD0Pq//f6JYPdnoWVq+jl31iD2Mvh7CLaspQ?= =?Windows-1252?Q?KsatxdOTQEVRUul+gEbsABcAEYQRF8RcSvSWyniHKujG4WSmv4hU8rIx?= =?Windows-1252?Q?BWWNB9mqI90QEs1paoc8enAqS1KgA+bS08pu4eCUElYU531PNi7upOQR?= =?Windows-1252?Q?EbrFK4DGu6PF1GI1ja74SiVmuQEF5LcEwC5m2//Y59iSOJWgKN0KTs2B?= =?Windows-1252?Q?50Xc8A8fwWunfn7JFre6+1nDF7H96w0ZOhbboD0B6uNGWFEgIpC7t5FR?= =?Windows-1252?Q?CB4hQ1OMOrf1ASHAGXzC8pXY+EYXTQSSJY42Ht/RoYfP+naS+58Y+cWY?= =?Windows-1252?Q?w5e5/hIeM6pCyg4qIxxGOZG0J7BeOAv+ZRokPxcFSyNCk2nV+BGrGpnr?= =?Windows-1252?Q?NbAc+KCtvvGN8/5gp64GZlyJq1x2QRvHrqUNpVUzLNi7z/NJjMRI7QQe?= =?Windows-1252?Q?t+qzfZQ2vDhY1hWRyffQRqw73ieBbyL1kcJa/FyAQK8uFrpBalrgRwhO?= =?Windows-1252?Q?GLxPB0uAtuiGyiBcSWm5TbjbE6c2Hr9rCXHhPVFLQsAK48ru7ZdEzqhs?= =?Windows-1252?Q?VBnpQhMvFSXkkKGxj4xGwKDBQyZ1xNE8GosRQN9a2XT28HJJR8mYffJr?= =?Windows-1252?Q?gAUBmcY5b5J1ySti0KpOhvY5q9HEeEQ5hUv12k6ZY6WIS3ckiIWTIqS3?= =?Windows-1252?Q?7x4fTSDBnvdopFjt8zZflRoLh6EvPCf1DeXHEkszU4wGB0qZ9FgiswwR?= =?Windows-1252?Q?1hxwXQyNFZ6jWh+0wKR54E2h7NdrNPqRFU//qpHyR3BuetyyNGp++OdP?= =?Windows-1252?Q?xnCrWdBt4tr76rW6MIYF3Iu5l04Wa3fdMCrKfeEskwerwT7hdA7A/Opv?= =?Windows-1252?Q?HzDPA45UdP0/CWjtelwQhtfn/ehyb7KMYm5eBo9qWELR0nCv3eDEyxT+?= =?Windows-1252?Q?7Mvfl6OXWzj4Xkl3PogrVCiY0TYl1ii+5aBQvJJ6upxHCR/kG/XxiiXA?= =?Windows-1252?Q?W29CNLzS7Nd3so5JkDUvgeAN2UXmj6Bae/8n82wjVzZ6pb9KjYCcNk?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;6:M0mRDLf0hcysS81o8zNy4a3Zp/77ZrFwv/WVyvy5JrHcPsKI6yYCGwb4VF+cZsCUpdJPRu/ml5l37h1RN1aia82BJjnVo1Z0bJaomW2yf/hKVIJUnS0cr+5euFviXvOW4qZfkJAIe5E9WZk/S0WoZcPEKG+1sRSCRL1bh+ruPZ/bjJQRaIW5cmpRfQGwOAi3ZMSIk17OlYosQPpGgegQ8VioqY5nqZSsfN3GV1uCjltaIXF7mlEIKvfhbIIiodNBbqgtSLnPt7SE4pusJyN0x+bQn9fXE6VK++ll/KVnkW+8LtaTCPS3ZFuFwqCO64lfIfT+Ovdp0SmFd0+IwgB3lgoWC0r+eUBvNV8606UMhxc=;5:ouPoovG/mQVxz+aJjE1W90efGE1V5SqG4AqUGzSYjG2W/kJMSOAjMAwqC0jhAHANUzpD5kKxzsgYaNlLOCm/NGMkw8MSVoUriqP+7cYX2QfKi3Vj+/lvSlPb4m1zdRvYVJQpEO6oDsUh5FqN81VGuQ==;24:oQmykEMsgcwBrswiacTX/kl8G5wGUAiLGwirYU8JqCNtF8od3eOEFWsy0t11B/OJQADtNdZkN9VCD+RjYXcPxnTbxqWS7hYZrJ2DIMvbA70= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1194;7:LPz+bODf5xnr+plwfk9g7exh5fC7HoG6AyUQFiNAtjJbZCsiEwL6s45o7t/h8Jk8uqSVGe4AZG51RwBWYmw/WBOFi2Jr7ln4JhDh6TyekqGv+IPMRVyiqD5C2PfI0XDBrdz/wwcT+ft61rKgWoDCrqmLnb2g6jyxx1mo4y5Gu3TR/IYrQ8ADnerEYGdNY7z4T+sM3XzTKHu9Ynv2irgYbFkSyvktR22hqkjBpkFned4fm12Z3hju1eYsQe5fZvV0QqLFZQpIMK6ovCN8+NBNDuvBsKIPjAC3YLu5RoYbgR+iPmuC5HkSsxH7sV/VHwrx+9fNT6tYAEnJjX5GCxWAUcYAqDB9UIIddbFQSS6MO3A=;20:uoD4GVQ0rDTzOoonTsVVv72KmX7DNvPniA0QqA5xPNzCRC4fdrhhvYBF9r2Ct98iuvWMjywQjpLPsJ9LbP+WaX+0biodKImxHLx5+Jyl5n3NJFWJsUybu8YbUIwnUUIE0No9dfdn28BSeXp2j7CY1Z3my+CQZn9GdXL9ioHH4ck= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2016 15:53:03.7765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1194 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-22_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 24 On 11/11/2016 05:05 AM, Ming Lei wrote: > Hi, > > This patchset cleans up direct access to bvec table. > > The 1st patch passes bvec table to bio_init(), so that > direct access to bvec table in bio initialization is avoided. > > For other patches, most of them uses bio_add_page() > to replace hardcode style of adding page to bvec, > and others avoids to access bio->bi_vcnt. > > The most special one is to use bvec iterator helpers > to implement .get_page/.next_page for dm-io.c > > One big motivation is to prepare for supporting multipage > bvec, but this patchset is one good cleanup too even not > for that purpose. I've added the series, except 6-8, the dm parts. I updated some of the descriptions/subjects to read a little better. -- Jens Axboe