Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755909AbcKVP5Q (ORCPT ); Tue, 22 Nov 2016 10:57:16 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38670 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479AbcKVP5O (ORCPT ); Tue, 22 Nov 2016 10:57:14 -0500 Date: Tue, 22 Nov 2016 16:00:13 +0000 From: Lee Jones To: Milo Kim Cc: bcousson@baylibre.com, Tony Lindgren , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Nelson Subject: Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Message-ID: <20161122160013.GH10134@dell.home> References: <20161121131515.8040-1-woogyom.kim@gmail.com> <20161122155759.GG10134@dell.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161122155759.GG10134@dell.home> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2213 Lines: 65 On Tue, 22 Nov 2016, Lee Jones wrote: > On Mon, 21 Nov 2016, Milo Kim wrote: > > > AC and USB interrupts are related with external power input. > > PB interrupt means push button pressed or released event. > > Use better human readable definitions. > > > > Signed-off-by: Milo Kim > > --- > > arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++-- > > include/dt-bindings/mfd/tps65217.h | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi > > index dc561d5..1848d58 100644 > > --- a/arch/arm/boot/dts/am335x-bone-common.dtsi > > +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi > > @@ -319,13 +319,13 @@ > > ti,pmic-shutdown-controller; > > > > charger { > > - interrupts = , ; > > + interrupts = , ; > > interrupts-names = "AC", "USB"; > > status = "okay"; > > }; > > > > pwrbutton { > > - interrupts = ; > > + interrupts = ; > > Push button or power button? > > > status = "okay"; > > }; > > > > diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h > > index cafb9e6..0293fdd 100644 > > --- a/include/dt-bindings/mfd/tps65217.h > > +++ b/include/dt-bindings/mfd/tps65217.h > > @@ -19,8 +19,8 @@ > > #ifndef __DT_BINDINGS_TPS65217_H__ > > #define __DT_BINDINGS_TPS65217_H__ > > > > -#define TPS65217_IRQ_USB 0 > > -#define TPS65217_IRQ_AC 1 > > -#define TPS65217_IRQ_PB 2 > > +#define TPS65217_IRQ_USB_POWER 0 /* USB power state change */ > > +#define TPS65217_IRQ_AC_POWER 1 /* AC power state change */ > > +#define TPS65217_IRQ_PUSHBUTTON 2 /* Push button state change */ > > This changes the ABI. > > It will require a DT Ack. Tell a lie. Sorry, I was getting false positives from my grep. It looks like you use the same scheme from within include/linux. I suggest that you probable don't want to do that. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog