Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbcKVQSE (ORCPT ); Tue, 22 Nov 2016 11:18:04 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54884 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755309AbcKVQSC (ORCPT ); Tue, 22 Nov 2016 11:18:02 -0500 Date: Tue, 22 Nov 2016 11:12:23 -0500 (EST) Message-Id: <20161122.111223.676925674747527292.davem@davemloft.net> To: gregory.clement@free-electrons.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: mvneta: Only disable mvneta_bm for 64-bits From: David Miller In-Reply-To: <20161122160037.14400-1-gregory.clement@free-electrons.com> References: <20161122160037.14400-1-gregory.clement@free-electrons.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Nov 2016 07:16:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uAMGILvI012706 Content-Length: 1480 Lines: 29 From: Gregory CLEMENT Date: Tue, 22 Nov 2016 17:00:37 +0100 > Actually only the mvneta_bm support is not 64-bits compatible. > The mvneta code itself can run on 64-bits architecture. > > Signed-off-by: Gregory CLEMENT No it cannot, it emits warnings because it casts pointers to and from 32-bit integers. I'm not applying this. drivers/net/ethernet/marvell/mvneta.c: In function ?mvneta_rx_refill?: drivers/net/ethernet/marvell/mvneta.c:1802:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] mvneta_rx_desc_fill(rx_desc, phys_addr, (u32)data); ^ drivers/net/ethernet/marvell/mvneta.c: In function ?mvneta_rxq_drop_pkts?: drivers/net/ethernet/marvell/mvneta.c:1864:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] void *data = (void *)rx_desc->buf_cookie; ^ drivers/net/ethernet/marvell/mvneta.c: In function ?mvneta_rx_swbm?: drivers/net/ethernet/marvell/mvneta.c:1902:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] data = (unsigned char *)rx_desc->buf_cookie; ^ drivers/net/ethernet/marvell/mvneta.c: In function ?mvneta_rx_hwbm?: drivers/net/ethernet/marvell/mvneta.c:2023:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] data = (unsigned char *)rx_desc->buf_cookie; ^