Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756213AbcKVQgV (ORCPT ); Tue, 22 Nov 2016 11:36:21 -0500 Received: from mail-qk0-f173.google.com ([209.85.220.173]:34348 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756065AbcKVQgT (ORCPT ); Tue, 22 Nov 2016 11:36:19 -0500 MIME-Version: 1.0 In-Reply-To: <20161104213536.28496-1-ahaslam@baylibre.com> References: <20161104213536.28496-1-ahaslam@baylibre.com> From: Axel Haslam Date: Tue, 22 Nov 2016 17:35:38 +0100 Message-ID: Subject: Re: [PATCH v3 0/2] regulator: handling of error conditions for usb drivers To: Mark Brown , Leanne Girdwood , Kevin Hilman , Sekhar Nori , David Lechner , robh+dt@kernel.org Cc: linux-kernel@vger.kernel.org, Axel Haslam Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 56 Hi Mark, On Fri, Nov 4, 2016 at 10:35 PM, Axel Haslam wrote: > Some usb drivers rely on external power switches/regulators > to for the port vbus. Some of these drivers are using > a plain gpio for the enable pin and also the over current > indicator pin. > > To make these drivers more generic, we can use a regulator > to handle vbus, and send and over current event, but we are > missing a way to transmit the over current pin status, which > the usb layer may poll at any time. > > We would like to move these drivers to use a regulator, this > would make the usb driver generic allowing to use any type > of regulator. Also, it would help removing code, making DT > migration simpler and avoiding new DT bindings for each driver. > > These patches do 2 things: > * Add a new API, that consumers can use to poll the regulator > error status. > * Extends the fixed regulator driver to handle an optional > over current gpio pin. > > Changes v2 -> v3 > * droped merged patch to add new API > * rebased on top of regulator-next > > Changes v1->v2 > * add new API to get error status instead of extending events (Mark) > * use gpiod for fixed regulator: This spears us extra platform > data and bindings > > Axel Haslam (2): > regulator: fixed: dt: Allow an optional over current pin > regulator: fixed: Handle optional overcurrent pin im wondering if you have these 2 patches in queue, if there are no objections would it be possible to take them? The DT binding is Acked by Rob, would you prefer i resend them with the Ack tag? Regards Axel. > > .../bindings/regulator/fixed-regulator.txt | 2 + > drivers/regulator/fixed.c | 59 ++++++++++++++++++++++ > 2 files changed, 61 insertions(+) > > -- > 2.10.1 >