Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756262AbcKVQhv convert rfc822-to-8bit (ORCPT ); Tue, 22 Nov 2016 11:37:51 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:37120 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755360AbcKVQhu (ORCPT ); Tue, 22 Nov 2016 11:37:50 -0500 From: Gregory CLEMENT To: David Miller Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: mvneta: Only disable mvneta_bm for 64-bits References: <20161122160037.14400-1-gregory.clement@free-electrons.com> <20161122.111223.676925674747527292.davem@davemloft.net> Date: Tue, 22 Nov 2016 17:37:47 +0100 In-Reply-To: <20161122.111223.676925674747527292.davem@davemloft.net> (David Miller's message of "Tue, 22 Nov 2016 11:12:23 -0500 (EST)") Message-ID: <87lgwbo4h0.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1917 Lines: 49 Hi David, On mar., nov. 22 2016, David Miller wrote: > From: Gregory CLEMENT > Date: Tue, 22 Nov 2016 17:00:37 +0100 > >> Actually only the mvneta_bm support is not 64-bits compatible. >> The mvneta code itself can run on 64-bits architecture. >> >> Signed-off-by: Gregory CLEMENT > > No it cannot, it emits warnings because it casts pointers to and > from 32-bit integers. > > I'm not applying this. > > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_refill’: > drivers/net/ethernet/marvell/mvneta.c:1802:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > mvneta_rx_desc_fill(rx_desc, phys_addr, (u32)data); > ^ > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rxq_drop_pkts’: > drivers/net/ethernet/marvell/mvneta.c:1864:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > void *data = (void *)rx_desc->buf_cookie; > ^ > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_swbm’: > drivers/net/ethernet/marvell/mvneta.c:1902:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > data = (unsigned char *)rx_desc->buf_cookie; > ^ > drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_rx_hwbm’: > drivers/net/ethernet/marvell/mvneta.c:2023:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > data = (unsigned char *)rx_desc->buf_cookie; > ^ Indeed! There was a missing patch for it that I had in my tree and I didn't submit yet. I am bout to doing it now. Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com